Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3722)

Unified Diff: chrome/browser/banners/app_banner_metrics.h

Issue 2259553002: Make AppBannerInfoBar install WebAPK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move logic to WebApkInstaller. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_metrics.h
diff --git a/chrome/browser/banners/app_banner_metrics.h b/chrome/browser/banners/app_banner_metrics.h
index 1ca8212631da3a7d4d196392c6d42130a12307ea..1b5c055fa514837c78d886f4831b12838d995fa4 100644
--- a/chrome/browser/banners/app_banner_metrics.h
+++ b/chrome/browser/banners/app_banner_metrics.h
@@ -24,7 +24,8 @@ enum DisplayEvent {
DISPLAY_EVENT_WEB_APP_BANNER_REQUESTED = 10,
DISPLAY_EVENT_NATIVE_APP_BANNER_CREATED = 11,
DISPLAY_EVENT_WEB_APP_BANNER_CREATED = 12,
- DISPLAY_EVENT_MAX = 13,
+ DISPLAY_EVENT_WEBAPK_BANNER_CREATED = 13,
+ DISPLAY_EVENT_MAX = 14,
};
// This enum backs a UMA histogram, so it should be treated as append-only.
@@ -34,7 +35,11 @@ enum InstallEvent {
INSTALL_EVENT_NATIVE_APP_INSTALL_STARTED = 22,
INSTALL_EVENT_NATIVE_APP_INSTALL_COMPLETED = 23,
INSTALL_EVENT_WEB_APP_INSTALLED = 24,
- INSTALL_EVENT_MAX = 25,
+ INSTALL_EVENT_WEBAPK_INSTALL_TRIGGERED = 25,
+ INSTALL_EVENT_WEBAPK_INSTALL_STARTED = 26,
+ INSTALL_EVENT_WEBAPK_INSTALL_COMPLETED = 27,
+ INSTALL_EVENT_WEBAPK_INSTALL_FAILED = 28,
+ INSTALL_EVENT_MAX = 29,
};
// This enum backs a UMA histogram, so it should be treated as append-only.
@@ -59,7 +64,10 @@ enum UserResponse {
USER_RESPONSE_WEB_APP_DISMISSED = 4,
USER_RESPONSE_NATIVE_APP_IGNORED = 5,
USER_RESPONSE_WEB_APP_IGNORED = 6,
- USER_RESPONSE_MAX = 7,
+ USER_RESPONSE_WEBAPK_ACCEPTED = 7,
+ USER_RESPONSE_WEBAPK_DISMISSED = 8,
+ USER_RESPONSE_WEBAPK_IGNORED = 9,
+ USER_RESPONSE_MAX = 10,
};
// This enum backs a UMA histogram, so it should be treated as append-only.

Powered by Google App Engine
This is Rietveld 408576698