Tune the account chooser on Mac.

Tune the account chooser on Mac.

- it should always have vertical margins of 8px.
- The focus ring is drawn in the new method since OS X 10.7.

BUG=633994
Committed: https://crrev.com/9f13a4c8d4b067616016e48c4a71aadecdc33b9d
Cr-Commit-Position: refs/heads/master@{#413207}

[vasilii, 2016-08-19 16:30:39]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 16:31:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2016-08-19 16:33:14]

vasilii@chromium.org changed reviewers:
+ vabr@chromium.org

[vasilii, 2016-08-19 16:33:15]

Hi Vaclav,

please review the CL.

[vabr (Chromium), 2016-08-19 16:54:41]

LGTM!

https://codereview.chromium.org/2259533006/diff/1/chrome/browser/ui/cocoa/pas...
File chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
(right):

https://codereview.chromium.org/2259533006/diff/1/chrome/browser/ui/cocoa/pas...
chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm:142:
cellHeight + 2 * kVerticalAvatarMargin)];
optional / just curious:

Looking at the comment at line 30, this expression is always at least
kCredentialHeight, and sometimes more. I'm not sure I understand why. If there
is an easy answer, perhaps add it to the comment on line 30?

[vasilii, 2016-08-19 17:02:27]

https://codereview.chromium.org/2259533006/diff/1/chrome/browser/ui/cocoa/pas...
File chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
(right):

https://codereview.chromium.org/2259533006/diff/1/chrome/browser/ui/cocoa/pas...
chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm:142:
cellHeight + 2 * kVerticalAvatarMargin)];
On 2016/08/19 16:54:40, vabr (Chromium) wrote:
> optional / just curious:
> 
> Looking at the comment at line 30, this expression is always at least
> kCredentialHeight, and sometimes more. I'm not sure I understand why. If there
> is an easy answer, perhaps add it to the comment on line 30?

Done.

[vasilii, 2016-08-19 17:02:35]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 17:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2016-08-19 17:07:47]

Thanks for the new comment, much clearer now!

LGTM.

Cheers,
Vaclav

[commit-bot: I haz the power, 2016-08-19 17:45:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 17:45:44]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-08-19 19:16:10]

The CQ bit was checked by vasilii@chromium.org

[commit-bot: I haz the power, 2016-08-19 19:16:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-19 19:20:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-19 19:21:58]

Description was changed from

==========
Tune the account chooser on Mac.

- it should always have vertical margins of 8px.
- The focus ring is drawn in the new method since OS X 10.7.

BUG=633994
==========

to

==========
Tune the account chooser on Mac.

- it should always have vertical margins of 8px.
- The focus ring is drawn in the new method since OS X 10.7.

BUG=633994

Committed: https://crrev.com/9f13a4c8d4b067616016e48c4a71aadecdc33b9d
Cr-Commit-Position: refs/heads/master@{#413207}
==========

[commit-bot: I haz the power, 2016-08-19 19:21:59]

Patchset 2 (id:??) landed as
https://crrev.com/9f13a4c8d4b067616016e48c4a71aadecdc33b9d
Cr-Commit-Position: refs/heads/master@{#413207}