Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5774)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java

Issue 2259533003: Use bounds instead of size for prerender requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
index 3d9de3f87b293ebbc6d6429b5fb00dd93d3bf9dc..8664e5130e04643946469de221eb7941b6d25752 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/PrerenderTestHelper.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.test.util;
+import android.graphics.Rect;
+
import junit.framework.Assert;
import org.chromium.base.ThreadUtils;
@@ -92,13 +94,14 @@ public class PrerenderTestHelper {
@Override
public ExternalPrerenderHandler call() throws Exception {
ExternalPrerenderHandler prerenderHandler = new ExternalPrerenderHandler();
- boolean didPrerender = prerenderHandler.addPrerender(
- currentTab.getProfile(), currentTab.getWebContents(), testUrl, null,
- currentTab.getContentViewCore().getRenderCoordinates()
+ Rect bounds = new Rect(
+ 0, 0, currentTab.getContentViewCore().getRenderCoordinates()
.getContentWidthPixInt(),
currentTab.getContentViewCore().getRenderCoordinates()
- .getContentHeightPixInt(),
- false);
+ .getContentHeightPixInt());
+ boolean didPrerender = prerenderHandler.addPrerender(
+ currentTab.getProfile(), currentTab.getWebContents(), testUrl, null,
+ bounds, false);
Assert.assertTrue("Failed to prerender test url: " + testUrl, didPrerender);
return prerenderHandler;
}
« no previous file with comments | « chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698