Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3118)

Unified Diff: chrome/browser/prerender/prerender_contents.h

Issue 2259533003: Use bounds instead of size for prerender requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/prerender_contents.h
diff --git a/chrome/browser/prerender/prerender_contents.h b/chrome/browser/prerender/prerender_contents.h
index 9a48784a6fdc2bcba3cd159b51fe00f7a58722ae..894b64c784a4936a883b2e3707d7e72721e0c199 100644
--- a/chrome/browser/prerender/prerender_contents.h
+++ b/chrome/browser/prerender/prerender_contents.h
@@ -23,7 +23,7 @@
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_contents_observer.h"
#include "content/public/common/referrer.h"
-#include "ui/gfx/geometry/size.h"
+#include "ui/gfx/geometry/rect.h"
class Profile;
@@ -110,12 +110,12 @@ class PrerenderContents : public content::NotificationObserver,
// Start rendering the contents in the prerendered state. If
// |is_control_group| is true, this will go through some of the mechanics of
- // starting a prerender, without actually creating the RenderView. |size|
- // indicates the rectangular dimensions that the prerendered page should be.
+ // starting a prerender, without actually creating the RenderView. |bounds|
+ // indicates the rectangle that the prerendered page should be in.
// |session_storage_namespace| indicates the namespace that the prerendered
// page should be part of.
virtual void StartPrerendering(
- const gfx::Size& size,
+ const gfx::Rect& bounds,
content::SessionStorageNamespace* session_storage_namespace);
// Verifies that the prerendering is not using too many resources, and kills
@@ -343,8 +343,8 @@ class PrerenderContents : public content::NotificationObserver,
// Origin for this prerender.
Origin origin_;
- // The size of the WebView from the launching page.
- gfx::Size size_;
+ // The bounds of the WebView from the launching page.
+ gfx::Rect bounds_;
typedef std::vector<history::HistoryAddPageArgs> AddPageVector;
« no previous file with comments | « chrome/browser/prerender/external_prerender_handler_android.cc ('k') | chrome/browser/prerender/prerender_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698