chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java - Issue 2259533003: Use bounds instead of size for prerender requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

Issue 2259533003: Use bounds instead of size for prerender requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments nit Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java ('k') | chrome/browser/android/offline_pages/prerender_adapter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

index 0489bd64293e3e18662c9426d6fd70cb2747d34f..a1cac090603fb46ec793e081b4cd0781092f884b 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java

@@ -6,6 +6,7 @@ package org.chromium.chrome.browser.prerender;

import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_NON_LOW_END_DEVICE;

+import android.graphics.Rect;

import android.os.Environment;

import android.test.suitebuilder.annotation.SmallTest;

@@ -114,7 +115,8 @@ public class ExternalPrerenderHandlerTest extends NativeLibraryTestBase {

@Override

public WebContents call() {

WebContents webContents =

- mExternalPrerenderHandler.addPrerender(mProfile, url, "", 0, 0, false);

+ mExternalPrerenderHandler.addPrerender(

+ mProfile, url, "", new Rect(), false);

assertNotNull(webContents);

assertTrue(mExternalPrerenderHandler.hasPrerenderedUrl(

mProfile, url, webContents));