Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2312)

Unified Diff: chrome/browser/prerender/external_prerender_handler_android.cc

Issue 2259533003: Use bounds instead of size for prerender requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compile on mac, update .mm Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prerender/external_prerender_handler_android.cc
diff --git a/chrome/browser/prerender/external_prerender_handler_android.cc b/chrome/browser/prerender/external_prerender_handler_android.cc
index 012c9017598711f55792b6dfd65a3602f769ab13..6c11c49cfd0b838c84fb645ff9be15488d25d878 100644
--- a/chrome/browser/prerender/external_prerender_handler_android.cc
+++ b/chrome/browser/prerender/external_prerender_handler_android.cc
@@ -57,8 +57,10 @@ bool ExternalPrerenderHandlerAndroid::AddPrerender(
const JavaParamRef<jobject>& jweb_contents,
const JavaParamRef<jstring>& jurl,
const JavaParamRef<jstring>& jreferrer,
- jint width,
- jint height,
+ jint top,
+ jint left,
+ jint bottom,
+ jint right,
jboolean prerender_on_cellular) {
Profile* profile = ProfileAndroid::FromProfileAndroid(jprofile);
@@ -91,12 +93,12 @@ bool ExternalPrerenderHandlerAndroid::AddPrerender(
prerender_manager->AddPrerenderOnCellularFromExternalRequest(
url, referrer,
web_contents->GetController().GetDefaultSessionStorageNamespace(),
- gfx::Size(width, height));
+ gfx::Rect(top, left, bottom, right));
} else {
prerender_handle_ = prerender_manager->AddPrerenderFromExternalRequest(
url, referrer,
web_contents->GetController().GetDefaultSessionStorageNamespace(),
- gfx::Size(width, height));
+ gfx::Rect(top, left, bottom, right));
}
return !!prerender_handle_;

Powered by Google App Engine
This is Rietveld 408576698