Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Side by Side Diff: chrome/browser/android/offline_pages/prerender_adapter_unittest.cc

Issue 2259533003: Use bounds instead of size for prerender requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments nit Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/prerender_adapter.h" 5 #include "chrome/browser/android/offline_pages/prerender_adapter.h"
6 6
7 #include "base/sys_info.h" 7 #include "base/sys_info.h"
8 #include "chrome/browser/prerender/prerender_manager_factory.h" 8 #include "chrome/browser/prerender/prerender_manager_factory.h"
9 #include "chrome/test/base/testing_profile.h" 9 #include "chrome/test/base/testing_profile.h"
10 #include "content/public/browser/browser_thread.h" 10 #include "content/public/browser/browser_thread.h"
(...skipping 13 matching lines...) Expand all
24 24
25 class StubPrerenderContents : public PrerenderContents { 25 class StubPrerenderContents : public PrerenderContents {
26 public: 26 public:
27 StubPrerenderContents(PrerenderManager* prerender_manager, 27 StubPrerenderContents(PrerenderManager* prerender_manager,
28 const GURL& url, 28 const GURL& url,
29 Origin origin); 29 Origin origin);
30 30
31 ~StubPrerenderContents() override; 31 ~StubPrerenderContents() override;
32 32
33 void StartPrerendering( 33 void StartPrerendering(
34 const gfx::Size& size, 34 const gfx::Rect& bounds,
35 content::SessionStorageNamespace* session_storage_namespace) override; 35 content::SessionStorageNamespace* session_storage_namespace) override;
36 36
37 void ReportStartEvent() { NotifyPrerenderStart(); } 37 void ReportStartEvent() { NotifyPrerenderStart(); }
38 void ReportOnLoadEvent() { NotifyPrerenderStopLoading(); } 38 void ReportOnLoadEvent() { NotifyPrerenderStopLoading(); }
39 void ReportDomContentEvent() { NotifyPrerenderDomContentLoaded(); } 39 void ReportDomContentEvent() { NotifyPrerenderDomContentLoaded(); }
40 void StopWithStatus(FinalStatus final_status) { Destroy(final_status); } 40 void StopWithStatus(FinalStatus final_status) { Destroy(final_status); }
41 }; 41 };
42 42
43 StubPrerenderContents::StubPrerenderContents( 43 StubPrerenderContents::StubPrerenderContents(
44 PrerenderManager* prerender_manager, 44 PrerenderManager* prerender_manager,
45 const GURL& url, 45 const GURL& url,
46 Origin origin) 46 Origin origin)
47 : PrerenderContents(prerender_manager, 47 : PrerenderContents(prerender_manager,
48 NULL, 48 NULL,
49 url, 49 url,
50 content::Referrer(), 50 content::Referrer(),
51 origin) {} 51 origin) {}
52 52
53 StubPrerenderContents::~StubPrerenderContents() {} 53 StubPrerenderContents::~StubPrerenderContents() {}
54 54
55 void StubPrerenderContents::StartPrerendering( 55 void StubPrerenderContents::StartPrerendering(
56 const gfx::Size& size, 56 const gfx::Rect& bounds,
57 content::SessionStorageNamespace* session_storage_namespace) { 57 content::SessionStorageNamespace* session_storage_namespace) {
58 prerendering_has_started_ = true; 58 prerendering_has_started_ = true;
59 } 59 }
60 60
61 class StubPrerenderContentsFactory : public PrerenderContents::Factory { 61 class StubPrerenderContentsFactory : public PrerenderContents::Factory {
62 public: 62 public:
63 StubPrerenderContentsFactory() 63 StubPrerenderContentsFactory()
64 : create_prerender_contents_called_(false), 64 : create_prerender_contents_called_(false),
65 last_prerender_contents_(nullptr) {} 65 last_prerender_contents_(nullptr) {}
66 66
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
259 EXPECT_EQ(FinalStatus::FINAL_STATUS_CANCELLED, adapter()->GetFinalStatus()); 259 EXPECT_EQ(FinalStatus::FINAL_STATUS_CANCELLED, adapter()->GetFinalStatus());
260 260
261 // Exercise access methods even though no interesting values set beneath. 261 // Exercise access methods even though no interesting values set beneath.
262 EXPECT_EQ(nullptr, adapter()->GetWebContents()); 262 EXPECT_EQ(nullptr, adapter()->GetWebContents());
263 263
264 adapter()->DestroyActive(); 264 adapter()->DestroyActive();
265 EXPECT_FALSE(adapter()->IsActive()); 265 EXPECT_FALSE(adapter()->IsActive());
266 } 266 }
267 267
268 } // namespace offline_pages 268 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698