chrome/browser/safe_browsing/safe_browsing_blocking_page.cc - Issue 2259523003: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 2259523003: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

index 1858c36a9ea5eb864ca632d3b7bc39015222c8e3..77139af9f4482d38fb85786399b02a40ccf25ec1 100644

--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

@@ -184,8 +184,8 @@ SafeBrowsingBlockingPage::SafeBrowsingBlockingPage(

rappor::LOW_FREQUENCY_SAFEBROWSING_RAPPOR_TYPE;

reporting_info.deprecated_rappor_report_type =

rappor::SAFEBROWSING_RAPPOR_TYPE;

- set_metrics_helper(base::WrapUnique(new ChromeMetricsHelper(

- web_contents, request_url(), reporting_info, GetSamplingEventName())));

+ set_metrics_helper(base::MakeUnique<ChromeMetricsHelper>(

+ web_contents, request_url(), reporting_info, GetSamplingEventName()));

metrics_helper()->RecordUserDecision(

security_interstitials::MetricsHelper::SHOW);

metrics_helper()->RecordUserInteraction(

« no previous file with comments | « chrome/browser/safe_browsing/permission_reporter.cc ('k') | chrome/browser/safe_browsing/safe_browsing_database.cc » ('j') | no next file with comments »