Fix gles2_conform_test failures when Mac switching to core profile

Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fafa4a96ec427026769ade2aef681d331850ef90
Cr-Commit-Position: refs/heads/master@{#412681}

[Zhenyao Mo, 2016-08-17 19:29:36]

Description was changed from

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
==========

to

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-08-17 19:29:54]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:30:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-08-17 19:34:39]

piman: Please review.

See
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu...
for the failing tests

This CL fixes
  GLES2ConformTest.GLCoverage_input_run
  GLES2ConformTest.GL2FixedTests_copy_texture_input_run

I am still investigating
  GLES2ConformTest.GL2Tests_fixed_data_type_input_run

[Zhenyao Mo, 2016-08-17 19:34:56]

Description was changed from

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Zhenyao Mo, 2016-08-17 19:38:36]

https://codereview.chromium.org/2259523002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.h (right):

https://codereview.chromium.org/2259523002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.h:34: void
DoCopyTexImage2DToLUMACompatabilityTexture(
Fix a typo

https://codereview.chromium.org/2259523002/diff/20001/gpu/gles2_conform_suppo...
File gpu/gles2_conform_support/gles2_conform_test.cc (right):

https://codereview.chromium.org/2259523002/diff/20001/gpu/gles2_conform_suppo...
gpu/gles2_conform_support/gles2_conform_test.cc:114: bool success =
base::GetAppOutputAndError(cmd_line, &output);
This makes debugging gles2_conform_test easier.

[Zhenyao Mo, 2016-08-17 19:38:43]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 19:39:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-08-17 20:10:19]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 20:10:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Zhenyao Mo, 2016-08-17 20:11:16]

https://codereview.chromium.org/2259523002/diff/40001/gpu/gles2_conform_suppo...
File gpu/gles2_conform_support/gles2_conform_test_expectations.txt (right):

https://codereview.chromium.org/2259523002/diff/40001/gpu/gles2_conform_suppo...
gpu/gles2_conform_support/gles2_conform_test_expectations.txt:28: 635081 WIN
LINUX MAC CHROMEOS : GL2Tests_fixed_data_type_input_run = FAIL
I really don't understand how this test could pass before on any platform - we
disallow FIXED type in command buffer.

[Zhenyao Mo, 2016-08-17 20:11:54]

GLES2ConformTest.GL2Tests_fixed_data_type_input_run failure is due to lack of
support in command buffer for FIXED data type.

[piman, 2016-08-17 20:30:46]

https://codereview.chromium.org/2259523002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2259523002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_decoder.cc:4333: return 0;
You need return surface_.get() ? surface_->GetBackingFrameBufferObject() : 0,
similar to GetBackbufferServiceId(), to account for surfaces that use a FBO
internally.

https://codereview.chromium.org/2259523002/diff/40001/gpu/gles2_conform_suppo...
File gpu/gles2_conform_support/gles2_conform_test_expectations.txt (right):

https://codereview.chromium.org/2259523002/diff/40001/gpu/gles2_conform_suppo...
gpu/gles2_conform_support/gles2_conform_test_expectations.txt:28: 635081 WIN
LINUX MAC CHROMEOS : GL2Tests_fixed_data_type_input_run = FAIL
On 2016/08/17 20:11:16, Zhenyao Mo wrote:
> I really don't understand how this test could pass before on any platform - we
> disallow FIXED type in command buffer.

Actually, we do support it, emulating it if needed. This is disabled by default,
but enabled with EnableFeatureCHROMIUM("pepper3d_support_fixed_attribs"). This
/should/ be exercised by the conformance tests, see Context::CreateService in
gpu/gles2_conform_support/egl/context.cc

[commit-bot: I haz the power, 2016-08-17 20:53:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 20:53:05]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-08-17 21:14:42]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[Zhenyao Mo, 2016-08-17 21:15:05]

Revised.  Please review again.

[commit-bot: I haz the power, 2016-08-17 21:15:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-08-17 21:20:32]

kbr@chromium.org changed reviewers:
+ kbr@chromium.org

[Ken Russell (switch to Gerrit), 2016-08-17 21:20:33]

Very good catches. LGTM from my standpoint.

https://codereview.chromium.org/2259523002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/gles2_cmd_copy_tex_image.h (right):

https://codereview.chromium.org/2259523002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/gles2_cmd_copy_tex_image.h:34: void
DoCopyTexImage2DToLUMACompatabilityTexture(
Actually it should be "Compatibility".

[Zhenyao Mo, 2016-08-17 21:27:22]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:27:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-08-17 21:44:09]

lgtm

[commit-bot: I haz the power, 2016-08-17 22:29:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 22:29:26]

Dry run: This issue passed the CQ dry run.

[Zhenyao Mo, 2016-08-17 22:58:47]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2016-08-17 22:58:47]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2259523002/#ps80001
(title: "fix typo")

[commit-bot: I haz the power, 2016-08-17 22:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 23:03:38]

Description was changed from

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-08-17 23:03:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-17 23:19:43]

Description was changed from

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix gles2_conform_test failures when Mac switching to core profile

BUG=635081
TEST=gles2_conform_test on FYI mac bots
R=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/fafa4a96ec427026769ade2aef681d331850ef90
Cr-Commit-Position: refs/heads/master@{#412681}
==========

[commit-bot: I haz the power, 2016-08-17 23:19:44]

Patchset 5 (id:??) landed as
https://crrev.com/fafa4a96ec427026769ade2aef681d331850ef90
Cr-Commit-Position: refs/heads/master@{#412681}