appengine/findit/waterfall/monitor_try_job_pipeline.py - Issue 2259513003: [Findit] Display last build bucket response to try job dashboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/monitor_try_job_pipeline.py

Issue 2259513003: [Findit] Display last build bucket response to try job dashboard (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Rebase Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « appengine/findit/templates/try_job_dashboard.html ('k') | appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/waterfall/monitor_try_job_pipeline.py

diff --git a/appengine/findit/waterfall/monitor_try_job_pipeline.py b/appengine/findit/waterfall/monitor_try_job_pipeline.py

index 2eac6c78f6bec49d42ad8c61ecc527d5f4dbc52c..0584130675192e97cdfaeab86d73b3af3545378f 100644

--- a/appengine/findit/waterfall/monitor_try_job_pipeline.py

+++ b/appengine/findit/waterfall/monitor_try_job_pipeline.py

@@ -62,10 +62,11 @@ def _GetError(buildbucket_response, buildbucket_error, timed_out):

# Check buildbucket_response.

buildbucket_failure_reason = buildbucket_response.get('failure_reason')

if buildbucket_failure_reason == 'BUILD_FAILURE':

- # Can occurr if an exception is thrown or the disk is full.

+ # Generic buildbucket-reported error which can occurr if an exception is

+ # thrown, disk is full, compile fails during a test try job, etc.

return (

{

- 'message': 'Compile failed unexpectedly.',

+ 'message': 'Buildbucket reported a general error.',

'reason': MonitorTryJobPipeline.UNKNOWN

try_job_error.INFRA_FAILURE