Let PowerSaveBlocker manager anchor view in Java side

ui/android/view_android.h

Index: ui/android/view_android.h
diff --git a/ui/android/view_android.h b/ui/android/view_android.h
index a996e6804bbc10fc38449e43b34be7937fab6942..17a1bafdce8ffac46211b8c93c26b5474cc3678e 100644
--- a/ui/android/view_android.h
+++ b/ui/android/view_android.h
@@ -86,18 +86,18 @@ class UI_ANDROID_EXPORT ViewAndroid {
   void SetAnchorRect(const base::android::JavaRef<jobject>& anchor,
                      const gfx::RectF& bounds);
 
- protected:
-  ViewAndroid* parent_;
-
- private:
-  void RemoveChild(ViewAndroid* child);
-
   // Returns the Java delegate for this view. This is used to delegate work
   // up to the embedding view (or the embedder that can deal with the
   // implementation details).
   const base::android::ScopedJavaLocalRef<jobject>

[boliu, 2016/08/19 18:49:58]

err, maybe return GlobalRef if this is public?

also this is held weakly from native side so two problems, and you are
completely hiding that fact, two problems:
caller will probably forget to null check
caller may hold the strong ref natively, which is bad

so maybe actually just return JavaObjectWeakGlobalRef instead?

[Jinsuk Kim, 2016/08/19 20:44:46]

Done.

       GetViewAndroidDelegate() const;
 
+ protected:
+  ViewAndroid* parent_;
+
+ private:
+  void RemoveChild(ViewAndroid* child);
+
   std::list<ViewAndroid*> children_;
   scoped_refptr<cc::Layer> layer_;
   JavaObjectWeakGlobalRef delegate_;