third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp - Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayer.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableAreaTest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

index 4a3d4a54238540f1a60f17931b90eb4a17fbbb44..f3710f0d20314c96e033feab385d84e7201682cc 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

@@ -1493,11 +1493,12 @@ static bool layerNeedsCompositedScrolling(PaintLayerScrollableArea::LCDTextMode

if (node && node->isElementNode() && (toElement(node)->compositorMutableProperties() & (CompositorMutableProperty::kScrollTop | CompositorMutableProperty::kScrollLeft)))

return true;

- // TODO(schenney) The color test alone is inadequate. When https://codereview.chromium.org/2196583002 lands

- // we should use PaintLayer::shouldPaintBackgroundOntoForeground() because we will not still get

- // LCD text unless the conditions there are met. It also unifies logic for scrolling compositing decisions.

+ // TODO(schenney): LCD Text also requires integer scroll offsets for the layer. While we

+ // use integer scroll offsets locally when !layer->compositor()->preferCompositingToLCDTextEnabled(),

+ // we do not check offsets accumulated from the root (including translates). crbug.com/644833

bool backgroundSupportsLCDText = RuntimeEnabledFeatures::compositeOpaqueScrollersEnabled()

- && !layer->layoutObject()->style()->visitedDependentColor(CSSPropertyBackgroundColor).hasAlpha();

+ && layer->shouldPaintBackgroundOntoScrollingContentsLayer()

+ && layer->backgroundIsKnownToBeOpaqueInRect(toLayoutBox(layer->layoutObject())->paddingBoxRect());

if (mode == PaintLayerScrollableArea::ConsiderLCDText

&& !layer->compositor()->preferCompositingToLCDTextEnabled()

&& !backgroundSupportsLCDText)