Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
index a4a6beda01478803728ea06224b4ddd4f7e0ce07..c8197c8353e627a584fd8af881a5ea51f70a8aaf 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.cpp
@@ -33,11 +33,6 @@ void CompositingReasonFinder::updateTriggers()
}
}
-bool CompositingReasonFinder::hasOverflowScrollTrigger() const
-{
- return m_compositingTriggers & OverflowScrollTrigger;
-}
-
bool CompositingReasonFinder::isMainFrame() const
{
return m_layoutView.document().isInMainFrame();
@@ -142,16 +137,11 @@ CompositingReasons CompositingReasonFinder::nonStyleDeterminedDirectReasons(cons
CompositingReasons directReasons = CompositingReasonNone;
LayoutObject* layoutObject = layer->layoutObject();
- if (hasOverflowScrollTrigger()) {
- if (layer->clipParent())
- directReasons |= CompositingReasonOutOfFlowClipping;
-
- if (layer->needsCompositedScrolling())
- directReasons |= CompositingReasonOverflowScrollingTouch;
- }
+ if (layer->needsCompositedScrolling())
+ directReasons |= CompositingReasonOverflowScrollingTouch;
// Composite |layer| if it is inside of an ancestor scrolling layer, but that
- // scrolling layer is not not on the stacking context ancestor chain of |layer|.
+ // scrolling layer is not on the stacking context ancestor chain of |layer|.
// See the definition of the scrollParent property in Layer for more detail.
if (const PaintLayer* scrollingAncestor = layer->ancestorScrollingLayer()) {
if (scrollingAncestor->needsCompositedScrolling() && layer->scrollParent())

Powered by Google App Engine
This is Rietveld 408576698