Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
index 263634c96d5b147266a773ec803c62f833cc8457..eb3080ff6ddc28e9f78d33c4cacc10b71fc6a0a1 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp
@@ -297,7 +297,7 @@ void CompositedLayerMapping::updateIsRootForIsolatedGroup()
void CompositedLayerMapping::updateBackgroundPaintsOntoScrollingContentsLayer()
{
- bool shouldPaintOntoScrollingContentsLayer = shouldPaintBackgroundOntoScrollingContentsLayer();
+ bool shouldPaintOntoScrollingContentsLayer = m_owningLayer.shouldPaintBackgroundOntoScrollingContentsLayer();
if (shouldPaintOntoScrollingContentsLayer != backgroundPaintsOntoScrollingContentsLayer()) {
m_backgroundPaintsOntoScrollingContentsLayer = shouldPaintOntoScrollingContentsLayer;
// If the background is no longer painted onto the scrolling contents
@@ -2582,14 +2582,6 @@ bool CompositedLayerMapping::invalidateLayerIfNoPrecedingEntry(size_t indexToCle
return false;
}
-bool CompositedLayerMapping::shouldPaintBackgroundOntoScrollingContentsLayer() const
-{
- return !m_owningLayer.isRootLayer()
- && m_owningLayer.scrollsOverflow()
- && m_owningLayer.layoutObject()->style()->hasEntirelyLocalBackground()
- && !m_owningLayer.stackingNode()->hasNegativeZOrderList();
-}
-
bool CompositedLayerMapping::updateSquashingLayerAssignment(PaintLayer* squashedLayer, size_t nextSquashedLayerIndex)
{
GraphicsLayerPaintInfo paintInfo;

Powered by Google App Engine
This is Rietveld 408576698