Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 426
427 // This returns true if our document is in a phase of its lifestyle during w hich 427 // This returns true if our document is in a phase of its lifestyle during w hich
428 // compositing state may legally be read. 428 // compositing state may legally be read.
429 bool isAllowedToQueryCompositingState() const; 429 bool isAllowedToQueryCompositingState() const;
430 430
431 // Don't null check this. 431 // Don't null check this.
432 // FIXME: Rename. 432 // FIXME: Rename.
433 CompositedLayerMapping* compositedLayerMapping() const; 433 CompositedLayerMapping* compositedLayerMapping() const;
434 GraphicsLayer* graphicsLayerBacking() const; 434 GraphicsLayer* graphicsLayerBacking() const;
435 GraphicsLayer* graphicsLayerBackingForScrolling() const; 435 GraphicsLayer* graphicsLayerBackingForScrolling() const;
436 // Returns true for layers with scrollable overflow which have a background
437 // that can be painted into the composited scrolling contents layer when it exist
438 // (i.e. the background can scroll with the content). When the background is also
439 // opaque this allows us to composite the scroller even on low DPI as we can
440 // draw with subpixel anti-aliasing.
441 bool shouldPaintBackgroundOntoScrollingContentsLayer() const;
436 // NOTE: If you are using hasCompositedLayerMapping to determine the state o f compositing for this layer, 442 // NOTE: If you are using hasCompositedLayerMapping to determine the state o f compositing for this layer,
437 // (and not just to do bookkeeping related to the mapping like, say, allocat ing or deallocating a mapping), 443 // (and not just to do bookkeeping related to the mapping like, say, allocat ing or deallocating a mapping),
438 // then you may have incorrect logic. Use compositingState() instead. 444 // then you may have incorrect logic. Use compositingState() instead.
439 // FIXME: This is identical to null checking compositedLayerMapping(), why n ot just call that? 445 // FIXME: This is identical to null checking compositedLayerMapping(), why n ot just call that?
440 bool hasCompositedLayerMapping() const { return m_rareData && m_rareData->co mpositedLayerMapping; } 446 bool hasCompositedLayerMapping() const { return m_rareData && m_rareData->co mpositedLayerMapping; }
441 void ensureCompositedLayerMapping(); 447 void ensureCompositedLayerMapping();
442 void clearCompositedLayerMapping(bool layerBeingDestroyed = false); 448 void clearCompositedLayerMapping(bool layerBeingDestroyed = false);
443 CompositedLayerMapping* groupedMapping() const { return m_rareData ? m_rareD ata->groupedMapping : nullptr; } 449 CompositedLayerMapping* groupedMapping() const { return m_rareData ? m_rareD ata->groupedMapping : nullptr; }
444 enum SetGroupMappingOptions { 450 enum SetGroupMappingOptions {
445 InvalidateLayerAndRemoveFromMapping, 451 InvalidateLayerAndRemoveFromMapping,
(...skipping 478 matching lines...) Expand 10 before | Expand all | Expand 10 after
924 930
925 } // namespace blink 931 } // namespace blink
926 932
927 #ifndef NDEBUG 933 #ifndef NDEBUG
928 // Outside the WebCore namespace for ease of invocation from gdb. 934 // Outside the WebCore namespace for ease of invocation from gdb.
929 void showLayerTree(const blink::PaintLayer*); 935 void showLayerTree(const blink::PaintLayer*);
930 void showLayerTree(const blink::LayoutObject*); 936 void showLayerTree(const blink::LayoutObject*);
931 #endif 937 #endif
932 938
933 #endif // Layer_h 939 #endif // Layer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698