third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background-will-change.html - Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background-will-change.html

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix comment. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background.html ('k') | third_party/WebKit/LayoutTests/compositing/overflow/overflow-scroll-with-opaque-background-will-change-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script>	1 <script>

2 if (window.testRunner)	2 if (window.testRunner)

3 window.testRunner.dumpAsText();	3 window.testRunner.dumpAsText();

4	4

5 function hasOpaqueCompositedScrollingContentsLayer(layer) {	5 function hasOpaqueCompositedScrollingContentsLayer(layer) {

6 if (layer.name == "Scrolling Contents Layer")	6 if (layer.name == "Scrolling Contents Layer")

7 return layer.contentsOpaque;	7 return layer.contentsOpaque;

8 if (layer.children) {	8 if (layer.children) {

9 for (var i = 0; i < layer.children.length; i++) {	9 for (var i = 0; i < layer.children.length; i++) {

10 if (hasOpaqueCompositedScrollingContentsLayer(layer.children[i]))	10 if (hasOpaqueCompositedScrollingContentsLayer(layer.children[i]))

(...skipping 28 matching lines...) Expand all Loading...
39 .spacer {	39 .spacer {

40 height: 300px;	40 height: 300px;

41 }	41 }

42 </style>	42 </style>

43 <!-- The scroller's Scrolling Contents Layer should be opaque due to the opaque	43 <!-- The scroller's Scrolling Contents Layer should be opaque due to the opaque

44 color background. Even though the background has a content-box clip there	44 color background. Even though the background has a content-box clip there

45 is no gap because the scroller has no padding. This means that we will be	45 is no gap because the scroller has no padding. This means that we will be

46 able to draw text with subpixel anti-aliasing.	46 able to draw text with subpixel anti-aliasing.

47 -->	47 -->

48 <div id="scroller"><div class="spacer"></div></div>	48 <div id="scroller"><div class="spacer"></div></div>

OLD	NEW