Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 2259493004: Fix Compositing of Opaque Scrolling Layers and Add Tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 420
421 // This returns true if our document is in a phase of its lifestyle during w hich 421 // This returns true if our document is in a phase of its lifestyle during w hich
422 // compositing state may legally be read. 422 // compositing state may legally be read.
423 bool isAllowedToQueryCompositingState() const; 423 bool isAllowedToQueryCompositingState() const;
424 424
425 // Don't null check this. 425 // Don't null check this.
426 // FIXME: Rename. 426 // FIXME: Rename.
427 CompositedLayerMapping* compositedLayerMapping() const; 427 CompositedLayerMapping* compositedLayerMapping() const;
428 GraphicsLayer* graphicsLayerBacking() const; 428 GraphicsLayer* graphicsLayerBacking() const;
429 GraphicsLayer* graphicsLayerBackingForScrolling() const; 429 GraphicsLayer* graphicsLayerBackingForScrolling() const;
430 // Returns true for layers with scrollable overflow which have a background
431 // that can be painted into the composited scrolling contents layer (i.e.
432 // the background can scroll with the content). When the background is also
433 // opaque this allows us to composite the scroller even on low DPI as we can
434 // draw with subpixel anti-aliasing.
435 bool shouldPaintBackgroundOntoScrollingContentsLayer() const;
430 // NOTE: If you are using hasCompositedLayerMapping to determine the state o f compositing for this layer, 436 // NOTE: If you are using hasCompositedLayerMapping to determine the state o f compositing for this layer,
431 // (and not just to do bookkeeping related to the mapping like, say, allocat ing or deallocating a mapping), 437 // (and not just to do bookkeeping related to the mapping like, say, allocat ing or deallocating a mapping),
432 // then you may have incorrect logic. Use compositingState() instead. 438 // then you may have incorrect logic. Use compositingState() instead.
433 // FIXME: This is identical to null checking compositedLayerMapping(), why n ot just call that? 439 // FIXME: This is identical to null checking compositedLayerMapping(), why n ot just call that?
434 bool hasCompositedLayerMapping() const { return m_rareData && m_rareData->co mpositedLayerMapping; } 440 bool hasCompositedLayerMapping() const { return m_rareData && m_rareData->co mpositedLayerMapping; }
435 void ensureCompositedLayerMapping(); 441 void ensureCompositedLayerMapping();
436 void clearCompositedLayerMapping(bool layerBeingDestroyed = false); 442 void clearCompositedLayerMapping(bool layerBeingDestroyed = false);
437 CompositedLayerMapping* groupedMapping() const { return m_rareData ? m_rareD ata->groupedMapping : nullptr; } 443 CompositedLayerMapping* groupedMapping() const { return m_rareData ? m_rareD ata->groupedMapping : nullptr; }
438 enum SetGroupMappingOptions { 444 enum SetGroupMappingOptions {
439 InvalidateLayerAndRemoveFromMapping, 445 InvalidateLayerAndRemoveFromMapping,
(...skipping 453 matching lines...) Expand 10 before | Expand all | Expand 10 after
893 899
894 } // namespace blink 900 } // namespace blink
895 901
896 #ifndef NDEBUG 902 #ifndef NDEBUG
897 // Outside the WebCore namespace for ease of invocation from gdb. 903 // Outside the WebCore namespace for ease of invocation from gdb.
898 void showLayerTree(const blink::PaintLayer*); 904 void showLayerTree(const blink::PaintLayer*);
899 void showLayerTree(const blink::LayoutObject*); 905 void showLayerTree(const blink::LayoutObject*);
900 #endif 906 #endif
901 907
902 #endif // Layer_h 908 #endif // Layer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698