[SVGDom] Add support for assorted absolute units

[SVGDom] Add support for assorted absolute units

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259473002

Committed: https://skia.googlesource.com/skia/+/280e282d2a89ba3b9ff05dd2475d7452b7dccdbe

[f(malita), 2016-08-17 18:21:38]

Description was changed from

==========
Add support for assorted absolute units

R=robertphillips@google.com,stephana@google.com
==========

to

==========
Add support for assorted absolute units

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259473002
==========

[f(malita), 2016-08-17 18:24:35]

Per https://www.w3.org/TR/SVG/coords.html#Units, these units are just a constant
multiplier for user units (regardless of DPI).  Yay!

[f(malita), 2016-08-17 18:24:41]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 18:24:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-08-17 18:39:03]

https://codereview.chromium.org/2259473002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2259473002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:28: 
// These all assume a 90dpi display device.

Do we not want to actually have an fDPI setting on SkSVGLengthContext and then
compute all these explicitly in resolve ?

https://codereview.chromium.org/2259473002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:30: constexpr SkScalar
kPXMultiplier =  1.00f;
Isn't the pt multiplier supposed to be DPI/72.272 ?

[commit-bot: I haz the power, 2016-08-17 19:25:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-17 19:25:10]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-08-17 21:04:17]

https://codereview.chromium.org/2259473002/diff/1/experimental/svg/model/SkSV...
File experimental/svg/model/SkSVGRenderContext.cpp (right):

https://codereview.chromium.org/2259473002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:28: 
On 2016/08/17 18:39:03, robertphillips wrote:
> // These all assume a 90dpi display device.
> 
> Do we not want to actually have an fDPI setting on SkSVGLengthContext and then
> compute all these explicitly in resolve ?

Done.

https://codereview.chromium.org/2259473002/diff/1/experimental/svg/model/SkSV...
experimental/svg/model/SkSVGRenderContext.cpp:30: constexpr SkScalar
kPXMultiplier =  1.00f;
On 2016/08/17 18:39:03, robertphillips wrote:
> Isn't the pt multiplier supposed to be DPI/72.272 ?

Done.

[f(malita), 2016-08-17 21:04:25]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 21:04:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[f(malita), 2016-08-17 21:35:19]

Description was changed from

==========
Add support for assorted absolute units

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259473002
==========

to

==========
[SVGDom] Add support for assorted absolute units

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259473002
==========

[robertphillips, 2016-08-17 21:42:37]

lgtm

[f(malita), 2016-08-17 21:45:39]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2016-08-17 21:45:44]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-08-17 21:45:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-17 21:51:05]

Description was changed from

==========
[SVGDom] Add support for assorted absolute units

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259473002
==========

to

==========
[SVGDom] Add support for assorted absolute units

R=robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259473002

Committed:
https://skia.googlesource.com/skia/+/280e282d2a89ba3b9ff05dd2475d7452b7dccdbe
==========

[commit-bot: I haz the power, 2016-08-17 21:51:05]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/280e282d2a89ba3b9ff05dd2475d7452b7dccdbe