Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2259453003:
Fixed DCHECK crash for radial gradients with very large values (Closed)
|
Created:
4 years, 4 months ago by sashab Modified:
4 years, 3 months ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFixed DCHECK crash for radial gradients with very large values
Fixed DCHECK crash for radial gradients specified with values near
infinity. This patch clamps the value to numeric_limit<float>.
BUG=638483
Committed: https://crrev.com/dca2fc113095eeae3361b27d44f7da8f61ac1501
Cr-Commit-Position: refs/heads/master@{#416852}
Patch Set 1 #Patch Set 2 : Simplified test #
Total comments: 4
Patch Set 3 : Done #
Total comments: 2
Patch Set 4 : Removed unused comment and rebased #Patch Set 5 : Rebased... forgot about this patch #
Messages
Total messages: 30 (18 generated)
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sashab@chromium.org changed reviewers: + bugsnash@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/gradients/css3-radial-gradients-inf-radius-crash.html (right): https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/gradients/css3-radial-gradients-inf-radius-crash.html:1: <!doctype html> Most layout tests capitalize DOCTYPE https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right): https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1171: secondRadius.setHeight(std::numeric_limits<float>::max()); Would it be better to put an infinity adjustment in CSSRadialGradientValue::resolveRadius?
The CQ bit was checked by sashab@chromium.org to run a CQ dry run
https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/fast/gradients/css3-radial-gradients-inf-radius-crash.html (right): https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/fast/gradients/css3-radial-gradients-inf-radius-crash.html:1: <!doctype html> On 2016/08/18 at 05:53:21, Bugs Nash wrote: > Most layout tests capitalize DOCTYPE Done. https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right): https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1171: secondRadius.setHeight(std::numeric_limits<float>::max()); On 2016/08/18 at 05:53:21, Bugs Nash wrote: > Would it be better to put an infinity adjustment in CSSRadialGradientValue::resolveRadius? Oh wow, because of you saying that I changed this to a 1-line fix :P And it uses clampTo() instead of this numeric_limits stuff. Nice!!
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/08/18 at 06:41:34, sashab wrote: > https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Layo... > File third_party/WebKit/LayoutTests/fast/gradients/css3-radial-gradients-inf-radius-crash.html (right): > > https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Layo... > third_party/WebKit/LayoutTests/fast/gradients/css3-radial-gradients-inf-radius-crash.html:1: <!doctype html> > On 2016/08/18 at 05:53:21, Bugs Nash wrote: > > Most layout tests capitalize DOCTYPE > > Done. > > https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Sour... > File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right): > > https://codereview.chromium.org/2259453003/diff/20001/third_party/WebKit/Sour... > third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1171: secondRadius.setHeight(std::numeric_limits<float>::max()); > On 2016/08/18 at 05:53:21, Bugs Nash wrote: > > Would it be better to put an infinity adjustment in CSSRadialGradientValue::resolveRadius? > > Oh wow, because of you saying that I changed this to a 1-line fix :P And it uses clampTo() instead of this numeric_limits stuff. Nice!! lgtm
sashab@chromium.org changed reviewers: + dstockwell@chromium.org
dstockwell@ for owners :)
lgtm https://codereview.chromium.org/2259453003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right): https://codereview.chromium.org/2259453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1016: if (radius->isNumber()) // Can the radius be a percentage? What's up with this comment?
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dstockwell@chromium.org, bugsnash@chromium.org Link to the patchset: https://codereview.chromium.org/2259453003/#ps60001 (title: "Removed unused comment and rebased")
https://codereview.chromium.org/2259453003/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/css/CSSGradientValue.cpp (right): https://codereview.chromium.org/2259453003/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/css/CSSGradientValue.cpp:1016: if (radius->isNumber()) // Can the radius be a percentage? On 2016/08/19 at 02:33:43, dstockwell wrote: > What's up with this comment? From https://chromium.googlesource.com/chromium/src/+/3b6f3437968728d621be8412fa50..., before we accounted for percentages :) removed.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by sashab@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dstockwell@chromium.org, bugsnash@chromium.org Link to the patchset: https://codereview.chromium.org/2259453003/#ps80001 (title: "Rebased... forgot about this patch")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== Fixed DCHECK crash for radial gradients with very large values Fixed DCHECK crash for radial gradients specified with values near infinity. This patch clamps the value to numeric_limit<float>. BUG=638483 ========== to ========== Fixed DCHECK crash for radial gradients with very large values Fixed DCHECK crash for radial gradients specified with values near infinity. This patch clamps the value to numeric_limit<float>. BUG=638483 Committed: https://crrev.com/dca2fc113095eeae3361b27d44f7da8f61ac1501 Cr-Commit-Position: refs/heads/master@{#416852} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/dca2fc113095eeae3361b27d44f7da8f61ac1501 Cr-Commit-Position: refs/heads/master@{#416852} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
