Capture All Groups in the Field Trial For Testing Studies

chrome/common/variations/fieldtrial_testing_config_schema.json

Index: chrome/common/variations/fieldtrial_testing_config_schema.json
diff --git a/chrome/common/variations/fieldtrial_testing_config_schema.json b/chrome/common/variations/fieldtrial_testing_config_schema.json
index 3f165735518e7db198091393739d3099e71b1431..b836524c6e39aeda2348c4dfb0970a8b237f88c8 100644
--- a/chrome/common/variations/fieldtrial_testing_config_schema.json
+++ b/chrome/common/variations/fieldtrial_testing_config_schema.json
@@ -5,37 +5,47 @@
 {
   "type_name": "FieldTrialTestingConfig",
   "schema": [{
-    "field": "groups",
+    "field": "studies",
     "type": "array",
     "contents": {
-      "type_name": "FieldTrialTestingGroup",
+      "type_name": "FieldTrialTestingStudy",
       "type": "struct",
       "fields": [
-        {"field": "study", "type": "string"},
-        {"field": "group_name", "type": "string"},
+        {"field": "name", "type": "string"},
         {
-          "field": "params",
+          "field": "groups",
           "type": "array",
           "contents": {
-            "type_name": "FieldTrialGroupParams",
+            "type_name": "FieldTrialTestingStudyGroup",

[Ilya Sherman, 2016/08/18 22:09:38]

nit: s/StudyGroup/ExperimentGroup or just Group

Technically, the lingo is that a "study" is a collection of groups, and an
"experiment" is an individual group.  "StudyGroup" is probably technically
correct, but I think a bit confusing, as it mixes the "study" and "experiment"
concepts somewhat.

[robliao, 2016/08/18 22:27:14]

Done. Went with just Group.

             "type": "struct",
             "fields": [
-              {"field": "key", "type": "string"},
-              {"field": "value", "type": "string"}
+              {"field": "name", "type": "string"},
+              {
+                "field": "params",
+                "type": "array",
+                "contents": {
+                  "type_name": "FieldTrialTestingStudyGroupsParams",

[Ilya Sherman, 2016/08/18 22:09:38]

(similar comment here)

[robliao, 2016/08/18 22:27:14]

Adjusted to FieldTrialTestingGroupParams

+                  "type": "struct",
+                  "fields": [
+                    {"field": "key", "type": "string"},
+                    {"field": "value", "type": "string"}
+                  ]
+                }
+              },
+              {
+                "field": "enable_features",
+                "type": "array",
+                "contents": { "type": "string"}
+              },
+              {
+                "field": "disable_features",
+                "type": "array",
+                "contents": { "type": "string"}
+              }
             ]
           }
-        },
-        {
-          "field": "enable_features",
-          "type": "array",
-          "contents": { "type": "string"}
-        },
-        {
-          "field": "disable_features",
-          "type": "array",
-          "contents": { "type": "string"}
         }
       ]
     }
   }]
-}
+}