Capture All Groups in the Field Trial For Testing Studies

chrome/common/variations/variations_util.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/variations/variations_util.h"
 
 #include <stddef.h>
 
 #include <string>
 #include <vector>
 
 #include "base/feature_list.h"
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_split.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/common/variations/fieldtrial_testing_config.h"
 #include "components/variations/variations_associated_data.h"
 #include "net/base/escape.h"
 
 namespace chrome_variations {
 
 namespace {
 
 std::string EscapeValue(const std::string& value) {
   return net::UnescapeURLComponent(
       value, net::UnescapeRule::PATH_SEPARATORS |
                  net::UnescapeRule::URL_SPECIAL_CHARS_EXCEPT_PATH_SEPARATORS);
 }
 
+void AssociateParamsFromGroup(const std::string& study_name,

[jwd, 2016/08/22 21:54:08]

Can you also switch to trial/group terminology in this file too too.

[robliao, 2016/08/22 22:55:23]

Done.

+                              const FieldTrialTestingGroup& group,
+                              base::FeatureList* feature_list) {
+  if (group.params_size != 0) {
+    std::map<std::string, std::string> params;
+    for (size_t i = 0; i < group.params_size; ++i) {
+      const FieldTrialTestingGroupParams& param = group.params[i];
+      params[param.key] = param.value;
+    }
+    variations::AssociateVariationParams(study_name, group.name, params);
+  }
+  base::FieldTrial* trial =
+      base::FieldTrialList::CreateFieldTrial(study_name, group.name);
+
+  if (!trial) {
+    DLOG(WARNING) << "Field trial config study skipped: " << study_name
+                  << "." << group.name
+                  << " (it is overridden from chrome://flags)";
+    return;
+  }
+
+  for (size_t i = 0; i < group.enable_features_size; ++i) {
+    feature_list->RegisterFieldTrialOverride(
+        group.enable_features[i], base::FeatureList::OVERRIDE_ENABLE_FEATURE,
+        trial);
+  }
+  for (size_t i = 0; i < group.disable_features_size; ++i) {
+    feature_list->RegisterFieldTrialOverride(
+        group.disable_features[i],
+        base::FeatureList::OVERRIDE_DISABLE_FEATURE, trial);
+  }
+}
+
 } // namespace
 
 bool AssociateParamsFromString(const std::string& varations_string) {
   // Format: Trial1.Group1:k1/v1/k2/v2,Trial2.Group2:k1/v1/k2/v2
   std::set<std::pair<std::string, std::string>> trial_groups;
   for (const base::StringPiece& experiment_group : base::SplitStringPiece(
            varations_string, ",",
            base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL)) {
     std::vector<base::StringPiece> experiment = base::SplitStringPiece(
         experiment_group, ":", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
@@ skipping 31 matching lines @@
       std::string value = EscapeValue(key_values[i + 1]);
       params[key] = value;
     }
     variations::AssociateVariationParams(trial, group, params);
   }
   return true;
 }
 
 void AssociateParamsFromFieldTrialConfig(const FieldTrialTestingConfig& config,
                                          base::FeatureList* feature_list) {
-  for (size_t i = 0; i < config.groups_size; ++i) {
-    const FieldTrialTestingGroup& group = config.groups[i];
-    if (group.params_size != 0) {
-      std::map<std::string, std::string> params;
-      for (size_t j = 0; j < group.params_size; ++j) {
-        const FieldTrialGroupParams& param = group.params[j];
-        params[param.key] = param.value;
-      }
-      variations::AssociateVariationParams(group.study, group.group_name,
-                                           params);
-    }
-    base::FieldTrial* trial =
-        base::FieldTrialList::CreateFieldTrial(group.study, group.group_name);
-
-    if (!trial) {
-      DLOG(WARNING) << "Field trial config study skipped: " << group.study
-                    << "." << group.group_name
-                    << " (it is overridden from chrome://flags)";
-      continue;
-    }
-
-    for (size_t j = 0; j < group.enable_features_size; ++j) {
-      feature_list->RegisterFieldTrialOverride(
-          group.enable_features[j], base::FeatureList::OVERRIDE_ENABLE_FEATURE,
-          trial);
-    }
-    for (size_t j = 0; j < group.disable_features_size; ++j) {
-      feature_list->RegisterFieldTrialOverride(
-          group.disable_features[j],
-          base::FeatureList::OVERRIDE_DISABLE_FEATURE, trial);
+  for (size_t i = 0; i < config.studies_size; ++i) {
+    const FieldTrialTestingStudy& study = config.studies[i];
+    if (study.groups_size > 0) {
+      AssociateParamsFromGroup(study.name, study.groups[0], feature_list);
+    } else {
+      DLOG(ERROR) << "Unexpected empty study: " << study.name;
     }
   }
 }
 
 void AssociateDefaultFieldTrialConfig(base::FeatureList* feature_list) {
   AssociateParamsFromFieldTrialConfig(kFieldTrialConfig, feature_list);
 }
 
 }  // namespace chrome_variations