Quick View: fixed the bug that 'No preview available' text is not shown.

Quick View: fixed the bug that 'No preview available' text is not shown.

Fixed the bug that 'No preview available' text is not shown when the element
for that does not exist when Files App is launched.

BUG=632726
TEST=manually confirmed translated text of 'No preview(playback) is available' is shown when audio, video or a folder in Drive is opened with Quick View using Japanese.

Committed: https://crrev.com/305f0e100a1a3563586c4ff01b47bdf3814ebe72
Cr-Commit-Position: refs/heads/master@{#413076}

[oka, 2016-08-19 02:16:02]

Description was changed from

==========
Quick View: fixed the bug that 'No preview available' text is not shown.

Fixed the bug that 'No preview available' text is not shown when the element
for that does not exist when Files App is launched.

BUG=632726
==========

to

==========
Quick View: fixed the bug that 'No preview available' text is not shown.

Fixed the bug that 'No preview available' text is not shown when the element
for that does not exist when Files App is launched.

BUG=632726
TEST=manually confirmed translated text of 'No preview(playback) is available'
is shown when audio, video or a folder in Drive is opened with Quick View using
Japanese.
==========

[oka, 2016-08-19 02:16:02]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-08-19 02:16:10]

PTAL.

[fukino, 2016-08-19 03:24:41]

It looks this introduces a circular dependency.
Can we pass the translated text to files-quick-view?

[oka, 2016-08-19 03:55:42]

Address comment.

[oka, 2016-08-19 03:57:36]

PTAL.

[fukino, 2016-08-19 05:24:42]

lgtm with an optional nit.

https://codereview.chromium.org/2259433004/diff/20001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/quick_view_controller.js
(right):

https://codereview.chromium.org/2259433004/diff/20001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_controller.js:27:
this.quickView_.noPlaybackText = str('QUICK_VIEW_NO_PLAYBACK_AVAILABLE');
optional nit: You can use i18-content attribute for <files-quick-view> tag in
main.html.

[oka, 2016-08-19 05:50:38]

Addressed comments

[oka, 2016-08-19 05:57:39]

nit

[oka, 2016-08-19 05:57:55]

PTAL.

[fukino, 2016-08-19 06:00:31]

still lgtm. Thanks!

[oka, 2016-08-19 06:41:50]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-08-19 06:42:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-08-19 06:42:42]

On 2016/08/19 06:00:31, fukino wrote:
> still lgtm. Thanks!

Ah, I already had LGTM. sorry.

[commit-bot: I haz the power, 2016-08-19 07:26:32]

Description was changed from

==========
Quick View: fixed the bug that 'No preview available' text is not shown.

Fixed the bug that 'No preview available' text is not shown when the element
for that does not exist when Files App is launched.

BUG=632726
TEST=manually confirmed translated text of 'No preview(playback) is available'
is shown when audio, video or a folder in Drive is opened with Quick View using
Japanese.
==========

to

==========
Quick View: fixed the bug that 'No preview available' text is not shown.

Fixed the bug that 'No preview available' text is not shown when the element
for that does not exist when Files App is launched.

BUG=632726
TEST=manually confirmed translated text of 'No preview(playback) is available'
is shown when audio, video or a folder in Drive is opened with Quick View using
Japanese.
==========

[commit-bot: I haz the power, 2016-08-19 07:26:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-19 07:29:35]

Description was changed from

==========
Quick View: fixed the bug that 'No preview available' text is not shown.

Fixed the bug that 'No preview available' text is not shown when the element
for that does not exist when Files App is launched.

BUG=632726
TEST=manually confirmed translated text of 'No preview(playback) is available'
is shown when audio, video or a folder in Drive is opened with Quick View using
Japanese.
==========

to

==========
Quick View: fixed the bug that 'No preview available' text is not shown.

Fixed the bug that 'No preview available' text is not shown when the element
for that does not exist when Files App is launched.

BUG=632726
TEST=manually confirmed translated text of 'No preview(playback) is available'
is shown when audio, video or a folder in Drive is opened with Quick View using
Japanese.

Committed: https://crrev.com/305f0e100a1a3563586c4ff01b47bdf3814ebe72
Cr-Commit-Position: refs/heads/master@{#413076}
==========

[commit-bot: I haz the power, 2016-08-19 07:29:36]

Patchset 4 (id:??) landed as
https://crrev.com/305f0e100a1a3563586c4ff01b47bdf3814ebe72
Cr-Commit-Position: refs/heads/master@{#413076}