Issue 2259433002: fixes #627, update DDC Future.then signature

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2259433002: fixes #627, update DDC Future.then signature (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly

Modified:
4 years, 4 months ago

Reviewers:
Leaf

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -10 lines)			Patch
M	lib/runtime/dart_sdk.js	View	9 chunks	+10 lines, -9 lines	0 comments	Download
M	tool/input_sdk/lib/async/future.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tool/sdk_expected_errors.txt	View	3 chunks	+5 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Jennifer Messerly

the errors should get better once we can upgrade Analyzer. But not sure what that ...

4 years, 4 months ago (2016-08-17 16:39:27 UTC) #2

Jennifer Messerly

4 years, 4 months ago (2016-08-17 17:25:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c17604968830fd30f8d6d05ddec2d599cde24638 (presubmit successful).