Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2259423002:
Settings Search: Make tooltip vertical. (Closed)
|
Created:
4 years, 4 months ago by tommycli Modified:
4 years, 4 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSettings Search: Make tooltip vertical.
BUG=633657
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/3bae501dc4cb4c7df5739f15efb7c5edb22b90ca
Cr-Commit-Position: refs/heads/master@{#413520}
Patch Set 1 #
Messages
Total messages: 20 (10 generated)
Description was changed from ========== Settings Search: Make tooltip vertical. BUG=633657 ========== to ========== Settings Search: Make tooltip vertical. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Settings Search: Make tooltip vertical. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Settings Search: Make tooltip vertical. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
tommycli@chromium.org changed reviewers: + dbeam@chromium.org
dbeam: PTAL. Mouse avoiding behavior to be added in followon CL. Pic here: http://imgur.com/a/asFJl
dbeam: PTAL Screnshots: http://imgur.com/a/Gfu3D
lgtm
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by tommycli@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Settings Search: Make tooltip vertical. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Settings Search: Make tooltip vertical. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Settings Search: Make tooltip vertical. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Settings Search: Make tooltip vertical. BUG=633657 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/3bae501dc4cb4c7df5739f15efb7c5edb22b90ca Cr-Commit-Position: refs/heads/master@{#413520} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3bae501dc4cb4c7df5739f15efb7c5edb22b90ca Cr-Commit-Position: refs/heads/master@{#413520} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
