Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 2259403002: arc: Fix crash on window close (on close race condition). (Closed)

Created:
4 years, 4 months ago by khmel
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

arc: Fix crash on window close (on close race condition). This handles race condition on window closing. TEST=Extended browser_tests TEST=Manually on device TEST=test_that -b veyron_minnie <IP> cheets_Notification BUG=638656 BUG=638261 TBR=reviewer@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2256273003 Cr-Commit-Position: refs/heads/master@{#412940} (cherry picked from commit 800987eb69027f6f34dff840b19c68a83065c6ae)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -4 lines) Patch
M chrome/browser/ui/ash/launcher/arc_app_window_launcher_controller.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc View 2 chunks +43 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259403002/1
4 years, 4 months ago (2016-08-19 22:55:18 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 4 months ago (2016-08-19 22:55:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259403002/1
4 years, 4 months ago (2016-08-19 22:56:31 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 22:58:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698