Upstream ErrorPageResponseProvider to be used in integration tests.

Upstream ErrorPageResponseProvider to be used in integration tests.

A response provider for DNS failures.

BUG=

Committed: https://crrev.com/cbe7b17289c80014528d418a99a1e10ae16fb89b
Cr-Commit-Position: refs/heads/master@{#413378}

[baxley, 2016-08-19 20:44:59]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2016-08-19 21:29:02]

lgtm; cleanup request is optional, but appreciated.
(especially using correct camel case for Dns)

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
File ios/web/public/test/response_providers/error_page_response_provider.h
(right):

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:11:
#include "base/macros.h"
Is this include necessary?

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:13: 
Include gurl.h?

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:24: static
GURL DNSFailureUrl();
GetDnsFailureUrl ?

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:26: static
GURL RedirectToDNSFailureUrl();
GetRedirectToDnsFailureUrl ?

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
File ios/web/public/test/response_providers/error_page_response_provider.mm
(right):

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.mm:23: if
(HtmlResponseProvider::CanHandleRequest(request) ||
Maybe

return HtmlResponseProvider::CanHandleRequest(request) || request.url ==
ErrorPageResponseProvider::RedirectToDNSFailureUrl();

[baxley, 2016-08-19 22:25:45]

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
File ios/web/public/test/response_providers/error_page_response_provider.h
(right):

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:11:
#include "base/macros.h"
On 2016/08/19 21:29:02, Eugene But wrote:
> Is this include necessary?

Done.

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:13: 
On 2016/08/19 21:29:02, Eugene But wrote:
> Include gurl.h?

Done.

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:24: static
GURL DNSFailureUrl();
On 2016/08/19 21:29:02, Eugene But wrote:
> GetDnsFailureUrl ?

Done.

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.h:26: static
GURL RedirectToDNSFailureUrl();
On 2016/08/19 21:29:02, Eugene But wrote:
> GetRedirectToDnsFailureUrl ?

Done.

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
File ios/web/public/test/response_providers/error_page_response_provider.mm
(right):

https://codereview.chromium.org/2259393002/diff/1/ios/web/public/test/respons...
ios/web/public/test/response_providers/error_page_response_provider.mm:23: if
(HtmlResponseProvider::CanHandleRequest(request) ||
On 2016/08/19 21:29:02, Eugene But wrote:
> Maybe
> 
> return HtmlResponseProvider::CanHandleRequest(request) || request.url ==
> ErrorPageResponseProvider::RedirectToDNSFailureUrl();

Done.

[baxley, 2016-08-19 22:25:51]

The CQ bit was checked by baxley@chromium.org

[baxley, 2016-08-19 22:25:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2259393002/#ps20001
(title: "comments addressed")

[commit-bot: I haz the power, 2016-08-19 22:26:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 00:16:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:16:40]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[baxley, 2016-08-21 17:46:17]

The CQ bit was checked by baxley@chromium.org

[commit-bot: I haz the power, 2016-08-21 17:46:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 20:26:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-21 20:28:13]

Description was changed from

==========
Upstream ErrorPageResponseProvider to be used in integration tests.

A response provider for DNS failures.

BUG=
==========

to

==========
Upstream ErrorPageResponseProvider to be used in integration tests.

A response provider for DNS failures.

BUG=

Committed: https://crrev.com/cbe7b17289c80014528d418a99a1e10ae16fb89b
Cr-Commit-Position: refs/heads/master@{#413378}
==========

[commit-bot: I haz the power, 2016-08-21 20:28:14]

Patchset 2 (id:??) landed as
https://crrev.com/cbe7b17289c80014528d418a99a1e10ae16fb89b
Cr-Commit-Position: refs/heads/master@{#413378}