Mojo EDK: Add tests to exercise races in handle transit

Mojo EDK: Add tests to exercise races in handle transit

Data pipe producer handles may change status while in transit
and the receiving end may never be notified of this change unless
they call MojoWait on the handle.

This fixes that, and adds test coverage to verify that the problem
does not exist and does not regress for data pipe consumers (fixed by
http://crrev.com/411707) or message pipe handles (don't currently
have this problem) either.

BUG=639363
R=yzshen@chromium.org

Committed: https://crrev.com/7cd99cc18b960e7d59109f16c53cad49ac09e7c4
Cr-Commit-Position: refs/heads/master@{#413356}

[Ken Rockot(use gerrit already), 2016-08-19 20:10:01]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[Ken Rockot(use gerrit already), 2016-08-19 20:10:25]

Description was changed from

==========
Mojo EDK: Add tests to exercise races in handle transit

Data pipe producer handles may change status while in transit
and the receiving end may never be notified of this change unless
they call MojoWait on the handle.

This fixes that, and adds test coverage to verify that the problem
does not exist and does not regress for data pipe consumers (fixed by
http://crrev.com/411707) or message pipe handles (don't currently
have this problem.)

BUG=639363
R=yzshen@chromium.org
==========

to

==========
Mojo EDK: Add tests to exercise races in handle transit

Data pipe producer handles may change status while in transit
and the receiving end may never be notified of this change unless
they call MojoWait on the handle.

This fixes that, and adds test coverage to verify that the problem
does not exist and does not regress for data pipe consumers (fixed by
http://crrev.com/411707) or message pipe handles (don't currently
have this problem) either.

BUG=639363
R=yzshen@chromium.org
==========

[commit-bot: I haz the power, 2016-08-19 20:10:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2016-08-19 20:10:51]

Please take a look, thanks!

[Ken Rockot(use gerrit already), 2016-08-19 20:12:00]

FWIW I was able to repro the same bug yhirano fixed for data pipe consumers, on
data pipe producers using these tests.

[commit-bot: I haz the power, 2016-08-19 21:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 21:18:42]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-08-19 21:22:36]

The CQ bit was checked by rockot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 21:23:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2016-08-19 22:20:05]

LGTM

https://codereview.chromium.org/2259363002/diff/20001/mojo/edk/system/multipr...
File mojo/edk/system/multiprocess_message_pipe_unittest.cc (right):

https://codereview.chromium.org/2259363002/diff/20001/mojo/edk/system/multipr...
mojo/edk/system/multiprocess_message_pipe_unittest.cc:1306: MojoHandle b =
handles[0];
optional, nit: it seems a little easier to read if we directly use an array to
refer to the handles here, and at line 1351.

[yzshen1, 2016-08-19 22:20:05]

LGTM

[Ken Rockot(use gerrit already), 2016-08-19 22:28:00]

Thanks!

https://codereview.chromium.org/2259363002/diff/20001/mojo/edk/system/multipr...
File mojo/edk/system/multiprocess_message_pipe_unittest.cc (right):

https://codereview.chromium.org/2259363002/diff/20001/mojo/edk/system/multipr...
mojo/edk/system/multiprocess_message_pipe_unittest.cc:1306: MojoHandle b =
handles[0];
On 2016/08/19 at 22:20:05, yzshen1 wrote:
> optional, nit: it seems a little easier to read if we directly use an array to
refer to the handles here, and at line 1351.

Done

[Ken Rockot(use gerrit already), 2016-08-19 22:28:01]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2016-08-19 22:28:02]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2259363002/#ps40001
(title: ".")

[commit-bot: I haz the power, 2016-08-19 22:28:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 00:29:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:29:17]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-08-20 00:40:47]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-20 00:41:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 03:06:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 03:06:54]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-08-20 06:44:57]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-20 06:45:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-20 07:27:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-20 07:28:02]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ken Rockot(use gerrit already), 2016-08-20 22:55:40]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2016-08-20 22:55:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-21 00:28:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-21 00:30:30]

Description was changed from

==========
Mojo EDK: Add tests to exercise races in handle transit

Data pipe producer handles may change status while in transit
and the receiving end may never be notified of this change unless
they call MojoWait on the handle.

This fixes that, and adds test coverage to verify that the problem
does not exist and does not regress for data pipe consumers (fixed by
http://crrev.com/411707) or message pipe handles (don't currently
have this problem) either.

BUG=639363
R=yzshen@chromium.org
==========

to

==========
Mojo EDK: Add tests to exercise races in handle transit

Data pipe producer handles may change status while in transit
and the receiving end may never be notified of this change unless
they call MojoWait on the handle.

This fixes that, and adds test coverage to verify that the problem
does not exist and does not regress for data pipe consumers (fixed by
http://crrev.com/411707) or message pipe handles (don't currently
have this problem) either.

BUG=639363
R=yzshen@chromium.org

Committed: https://crrev.com/7cd99cc18b960e7d59109f16c53cad49ac09e7c4
Cr-Commit-Position: refs/heads/master@{#413356}
==========

[commit-bot: I haz the power, 2016-08-21 00:30:31]

Patchset 3 (id:??) landed as
https://crrev.com/7cd99cc18b960e7d59109f16c53cad49ac09e7c4
Cr-Commit-Position: refs/heads/master@{#413356}