Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4062)

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view.cc

Issue 2259353002: Update Flaky ToolbarActionViewInteractiveUITests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nits Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/toolbar_action_view.cc
diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
index f7e78445bf0cff82c7c51a016b5fde3d611aafff..49728f72a9da401ba4595be3df16a80d120eaeda 100644
--- a/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
@@ -43,10 +43,6 @@ namespace {
// handled directly by the Image.
const int kBorderInset = 0;
-// The callback to call directly before showing the context menu.
-ToolbarActionView::ContextMenuCallback* context_menu_callback_for_test =
- nullptr;
-
} // namespace
////////////////////////////////////////////////////////////////////////////////
@@ -167,6 +163,10 @@ void ToolbarActionView::OnMenuButtonClicked(views::MenuButton* sender,
}
}
+bool ToolbarActionView::IsMenuRunningForTesting() const {
+ return IsMenuRunning();
+}
+
void ToolbarActionView::OnMenuClosed() {
menu_runner_.reset();
menu_ = nullptr;
@@ -178,11 +178,6 @@ gfx::ImageSkia ToolbarActionView::GetIconForTest() {
return GetImage(views::Button::STATE_NORMAL);
}
-void ToolbarActionView::set_context_menu_callback_for_testing(
- base::Callback<void(ToolbarActionView*)>* callback) {
- context_menu_callback_for_test = callback;
-}
-
gfx::Size ToolbarActionView::GetPreferredSize() const {
return gfx::Size(ToolbarActionsBar::IconWidth(false),
ToolbarActionsBar::IconHeight());
@@ -302,8 +297,6 @@ void ToolbarActionView::DoShowContextMenu(
menu_ = menu_adapter_->CreateMenu();
menu_runner_.reset(new views::MenuRunner(menu_, run_types));
- if (context_menu_callback_for_test)
- context_menu_callback_for_test->Run(this);
ignore_result(
menu_runner_->RunMenuAt(parent, this, gfx::Rect(screen_loc, size()),
views::MENU_ANCHOR_TOPLEFT, source_type));

Powered by Google App Engine
This is Rietveld 408576698