Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: src/objects.cc

Issue 225933002: ElementsAccessor's public interface handlification. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/elements.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4480 matching lines...) Expand 10 before | Expand all | Expand 10 after
4491 object, receiver, index, continue_search); 4491 object, receiver, index, continue_search);
4492 } 4492 }
4493 4493
4494 4494
4495 PropertyAttributes JSObject::GetElementAttributeWithoutInterceptor( 4495 PropertyAttributes JSObject::GetElementAttributeWithoutInterceptor(
4496 Handle<JSObject> object, 4496 Handle<JSObject> object,
4497 Handle<JSReceiver> receiver, 4497 Handle<JSReceiver> receiver,
4498 uint32_t index, 4498 uint32_t index,
4499 bool continue_search) { 4499 bool continue_search) {
4500 PropertyAttributes attr = object->GetElementsAccessor()->GetAttributes( 4500 PropertyAttributes attr = object->GetElementsAccessor()->GetAttributes(
4501 *receiver, *object, index); 4501 receiver, object, index);
4502 if (attr != ABSENT) return attr; 4502 if (attr != ABSENT) return attr;
4503 4503
4504 // Handle [] on String objects. 4504 // Handle [] on String objects.
4505 if (object->IsStringObjectWithCharacterAt(index)) { 4505 if (object->IsStringObjectWithCharacterAt(index)) {
4506 return static_cast<PropertyAttributes>(READ_ONLY | DONT_DELETE); 4506 return static_cast<PropertyAttributes>(READ_ONLY | DONT_DELETE);
4507 } 4507 }
4508 4508
4509 if (!continue_search) return ABSENT; 4509 if (!continue_search) return ABSENT;
4510 4510
4511 Handle<Object> proto(object->GetPrototype(), object->GetIsolate()); 4511 Handle<Object> proto(object->GetPrototype(), object->GetIsolate());
(...skipping 11974 matching lines...) Expand 10 before | Expand all | Expand 10 after
16486 #define ERROR_MESSAGES_TEXTS(C, T) T, 16486 #define ERROR_MESSAGES_TEXTS(C, T) T,
16487 static const char* error_messages_[] = { 16487 static const char* error_messages_[] = {
16488 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS) 16488 ERROR_MESSAGES_LIST(ERROR_MESSAGES_TEXTS)
16489 }; 16489 };
16490 #undef ERROR_MESSAGES_TEXTS 16490 #undef ERROR_MESSAGES_TEXTS
16491 return error_messages_[reason]; 16491 return error_messages_[reason];
16492 } 16492 }
16493 16493
16494 16494
16495 } } // namespace v8::internal 16495 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/elements.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698