Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 22593003: Add flag trap_on_stub_deopt. We want to be able to trap on hydrogen stub bailouts. (Closed)

Created:
7 years, 4 months ago by mvstanton
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add flag trap_on_stub_deopt. We want to be able to trap on hydrogen stub bailouts. BUG= R=svenpanne@chromium.org, verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16121

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comments, added mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
PTAL, thanks! --Michael
7 years, 4 months ago (2013-08-07 15:41:37 UTC) #1
Toon Verwaest
lgtm
7 years, 4 months ago (2013-08-07 16:46:30 UTC) #2
Sven Panne
LGTM iff the copy-n-paste is removed (it's the small things that make our code base ...
7 years, 4 months ago (2013-08-08 06:31:28 UTC) #3
mvstanton
Thanks guys. Thx Sven for the pointers, I've updated on those lines. I've got the ...
7 years, 4 months ago (2013-08-09 08:22:20 UTC) #4
mvstanton
7 years, 4 months ago (2013-08-09 08:24:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r16121 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698