Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8024)

Unified Diff: build/config/sanitizers/sanitizers.gni

Issue 2259293002: Enable CFI for virtual calls on Linux x86-64 official builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert gyp Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/sanitizers/sanitizers.gni
diff --git a/build/config/sanitizers/sanitizers.gni b/build/config/sanitizers/sanitizers.gni
index 40ffb94d09885f6b6ed056860db472e0bc186bfe..132512d2529c50cd90ba692f3265dd8a79fe22ca 100644
--- a/build/config/sanitizers/sanitizers.gni
+++ b/build/config/sanitizers/sanitizers.gni
@@ -2,6 +2,8 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/config/chrome_build.gni")
+
declare_args() {
# Compile for Address Sanitizer to find memory bugs.
is_asan = false
@@ -50,8 +52,9 @@ declare_args() {
# Compile with Control Flow Integrity to protect virtual calls and casts.
# See http://clang.llvm.org/docs/ControlFlowIntegrity.html
#
- # TODO(pcc): Remove this flag if/when CFI is enabled in official builds.
- is_cfi = false
+ # TODO(pcc): Remove this flag if/when CFI is enabled in all official builds.
+ is_cfi = target_os == "linux" && !is_chromeos && target_cpu == "x64" &&
+ is_chrome_branded && is_official_build
# Enable checks for bad casts: derived cast and unrelated cast.
# TODO(krasin): remove this, when we're ready to add these checks by default.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698