build/common.gypi - Issue 2259293002: Enable CFI for virtual calls on Linux x86-64 official builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 2259293002: Enable CFI for virtual calls on Linux x86-64 official builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index cde40e911c18458c621d832a3d61461fc766e906..6e5206bccaf962c8cb8ce0ed70c9429aa256b47b 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -848,7 +848,7 @@

# This requires LLVM Gold plugin to be downloaded.

# See src/tools/clang/scripts/update.py

['OS=="linux" and target_arch=="x64" and buildtype=="Official" and branding=="Chrome" and chromeos==0', {

- 'use_lto%': 1,

+ 'cfi_vptr%': 1,

Dirk Pranke 2016/08/19 20:22:09 you don't really need to change GYP at this point.

krasin 2016/08/19 20:30:45 That's useful to know. Reverted. I am very glad t

}],

# Enable hotwording on Chrome-branded ChromeOS builds.

« no previous file with comments | « no previous file | build/config/sanitizers/sanitizers.gni » ('j') | build/config/sanitizers/sanitizers.gni » ('J')