Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: components/arc/ime/arc_ime_service.h

Issue 2259243002: arc: Use exo::WMHelper to abserve window focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/arc/ime/arc_ime_service.cc » ('j') | components/arc/ime/arc_ime_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/ime/arc_ime_service.h
diff --git a/components/arc/ime/arc_ime_service.h b/components/arc/ime/arc_ime_service.h
index 52387b91bc1fbd4517f11f72f5836871b9f127f5..e4d2d07bcba04063be540e103a51c813e7a511ad 100644
--- a/components/arc/ime/arc_ime_service.h
+++ b/components/arc/ime/arc_ime_service.h
@@ -10,7 +10,7 @@
#include "base/macros.h"
#include "components/arc/arc_service.h"
#include "components/arc/ime/arc_ime_bridge.h"
-#include "ui/aura/client/focus_change_observer.h"
+#include "components/exo/wm_helper.h"
#include "ui/aura/env_observer.h"
#include "ui/aura/window_observer.h"
#include "ui/aura/window_tracker.h"
@@ -22,10 +22,6 @@
#include "ui/keyboard/keyboard_controller_observer.h"
namespace aura {
-namespace client {
-class FocusClient;
-}
-
class Window;
}
@@ -42,8 +38,7 @@ class ArcBridgeService;
class ArcImeService : public ArcService,
public ArcImeBridge::Delegate,
public aura::EnvObserver,
- public aura::WindowObserver,
- public aura::client::FocusChangeObserver,
+ public exo::WMHelper::FocusObserver,
public keyboard::KeyboardControllerObserver,
public ui::TextInputClient {
public:
@@ -59,10 +54,7 @@ class ArcImeService : public ArcService,
// Overridden from aura::EnvObserver:
void OnWindowInitialized(aura::Window* new_window) override;
- // Overridden from aura::WindowObserver:
- void OnWindowAddedToRootWindow(aura::Window* window) override;
-
- // Overridden from aura::client::FocusChangeObserver:
+ // Overridden from exo::WMHelper::FocusObserver:
void OnWindowFocused(aura::Window* gained_focus,
aura::Window* lost_focus) override;
@@ -118,13 +110,12 @@ class ArcImeService : public ArcService,
gfx::Rect cursor_rect_;
bool has_composition_text_;
- aura::WindowTracker arc_windows_;
aura::WindowTracker focused_arc_window_;
- aura::client::FocusClient* focus_client_;
keyboard::KeyboardController* keyboard_controller_;
ui::InputMethod* test_input_method_;
+ bool is_focus_observer_installed_;
DISALLOW_COPY_AND_ASSIGN(ArcImeService);
};
« no previous file with comments | « no previous file | components/arc/ime/arc_ime_service.cc » ('j') | components/arc/ime/arc_ime_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698