Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 2259233002: Step 1 of opts_crc32 rollout. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Step 1 of opts_crc32 rollout. - This adds an crc32_sources variable to opts.gypi and hooks it into our GYP build with a dummy source file. Step 2 will hook crc32_sources into Chrome's GN build. Step 3 will actually land some code using CRC32 instructions. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259233002 Committed: https://skia.googlesource.com/skia/+/9c3887c975ae00a5c5522c2dfb367d13c0601953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M gyp/opts.gyp View 2 chunks +17 lines, -0 lines 0 comments Download
M gyp/opts.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mtklein_C
4 years, 4 months ago (2016-08-19 14:11:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259233002/1
4 years, 4 months ago (2016-08-19 14:11:20 UTC) #5
msarett
lgtm
4 years, 4 months ago (2016-08-19 15:06:09 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 15:07:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9c3887c975ae00a5c5522c2dfb367d13c0601953

Powered by Google App Engine
This is Rietveld 408576698