Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 225923002: Refactoring to allow adding new structured types (Closed)

Created:
6 years, 8 months ago by rossberg
Modified:
6 years, 8 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Refactoring to allow adding new structured types Also, simplfy representation of zone types, using a simple struct. R=bmeurer@chromium.org BUG= LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+224 lines, -287 lines) Patch
M src/types.h View 7 chunks +63 lines, -66 lines 0 comments Download
M src/types.cc View 17 chunks +68 lines, -68 lines 0 comments Download
M src/types-inl.h View 6 chunks +68 lines, -136 lines 0 comments Download
M test/cctest/test-types.cc View 2 chunks +25 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
6 years, 8 months ago (2014-04-04 13:10:23 UTC) #1
Benedikt Meurer
LGTM
6 years, 8 months ago (2014-04-07 07:14:07 UTC) #2
rossberg
6 years, 8 months ago (2014-04-07 11:00:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20538 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698