Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2259203002: Remove video-test.js file (Closed)

Created:
4 years, 4 months ago by Srirama
Modified:
4 years, 4 months ago
Reviewers:
fs, foolip
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove video-test.js file It is now used only in media-fragments tests. So moved the required functionality to media-fragments.js and deleted video-test.js BUG=588956 Committed: https://crrev.com/82f6b671e88d6ec78825b30bc8e96f207c0840e6 Cr-Commit-Position: refs/heads/master@{#413126}

Patch Set 1 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -435 lines) Patch
M third_party/WebKit/LayoutTests/media/media-fragments/TC0001.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0002.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0003.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0004.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0005.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0006.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0009.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0011.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0012.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0014.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0015.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0017.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0024.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0027.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0028.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0029.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0030.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0031.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0032.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0034.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0035.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0036.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0037.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0038.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0039.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0044.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0051.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0052.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0053.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0054.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0055.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0058.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0059.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0061.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0062.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0063.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0064.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0065.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0066.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0067.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0068.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0069.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0070.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0071.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0072.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0073.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0074.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0075.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0076.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0077.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0078.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0079.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0080.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0081.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0082.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0083.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0084.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0085.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0086.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0087.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0088.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0089.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0090.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0091.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0092.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0093.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/TC0094.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/media-fragments/media-fragments.js View 3 chunks +123 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-test.js View 1 chunk +0 lines, -366 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Srirama
PTAL
4 years, 4 months ago (2016-08-19 11:52:29 UTC) #5
fs
lgtm
4 years, 4 months ago (2016-08-19 11:55:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259203002/20001
4 years, 4 months ago (2016-08-19 12:14:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 4 months ago (2016-08-19 13:49:50 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 13:51:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82f6b671e88d6ec78825b30bc8e96f207c0840e6
Cr-Commit-Position: refs/heads/master@{#413126}

Powered by Google App Engine
This is Rietveld 408576698