Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2259183002: Fix a bug in "network stable" check of FirstMeaningfulPaint (Closed)

Created:
4 years, 4 months ago by Kunihiko Sakamoto
Modified:
4 years, 4 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in "network stable" check of FirstMeaningfulPaint This fixes a bug where FirstMeaningfulPaintDetector stopped observing layouts too early, because the conditional of ResourceFetcher::hasPendingRequest was wrong. BUG=632081 Committed: https://crrev.com/65d47fee609fe53951c1317efd34a2414281dd3a Cr-Commit-Position: refs/heads/master@{#413317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Kunihiko Sakamoto
4 years, 4 months ago (2016-08-19 06:18:00 UTC) #2
kouhei (in TOK)
lgtm
4 years, 4 months ago (2016-08-19 06:18:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259183002/1
4 years, 4 months ago (2016-08-19 06:18:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/276837)
4 years, 4 months ago (2016-08-19 09:38:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259183002/1
4 years, 4 months ago (2016-08-20 00:53:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 04:00:04 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 04:02:25 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65d47fee609fe53951c1317efd34a2414281dd3a
Cr-Commit-Position: refs/heads/master@{#413317}

Powered by Google App Engine
This is Rietveld 408576698