chrome/browser/resources/settings/settings_main/settings_main.html - Issue 2259163002: MD Settings: Fix scrolling bugs and hacks caused by undefined load behavior

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/settings_main/settings_main.html

Issue 2259163002: MD Settings: Fix scrolling bugs and hacks caused by undefined load behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TransitionsNoTestsFakeRebase

Patch Set: rebase Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/settings.html ('k') | chrome/browser/resources/settings/settings_page/main_page_behavior.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/settings_main/settings_main.html

diff --git a/chrome/browser/resources/settings/settings_main/settings_main.html b/chrome/browser/resources/settings/settings_main/settings_main.html

index 5000ceafa48f8325a0f571a89332f4bf09625472..23b59bda7b95e12f699d23f7fc9540d1a9244359 100644

--- a/chrome/browser/resources/settings/settings_main/settings_main.html

+++ b/chrome/browser/resources/settings/settings_main/settings_main.html

@@ -63,7 +63,7 @@

</div>

<template is="dom-if" if="[[showBasicPage_(

showPages_.basic, inSearchMode_, hasExpandedSection_)]]">

- <settings-basic-page route="BASIC" prefs="{{prefs}}"

+ <settings-basic-page prefs="{{prefs}}"

page-visibility="[[pageVisibility]]"

on-subpage-expand="onSubpageExpand_"

on-freeze-scroll="onFreezeScroll_">

@@ -84,7 +84,7 @@

</template>

<template is="dom-if" if="[[showAdvancedPage_(

showPages_.advanced, inSearchMode_, hasExpandedSection_)]]">

- <settings-advanced-page route="ADVANCED" prefs="{{prefs}}"

+ <settings-advanced-page prefs="{{prefs}}"

page-visibility="[[pageVisibility]]"

on-subpage-expand="onSubpageExpand_"

on-freeze-scroll="onFreezeScroll_">

@@ -92,7 +92,7 @@

</template>

- <settings-about-page route="ABOUT"></settings-about-page>

+ <settings-about-page></settings-about-page>

</template>

</template>