chrome/browser/resources/settings/settings.html - Issue 2259163002: MD Settings: Fix scrolling bugs and hacks caused by undefined load behavior

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/settings.html

Issue 2259163002: MD Settings: Fix scrolling bugs and hacks caused by undefined load behavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@TransitionsNoTestsFakeRebase

Patch Set: bug fixes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/settings_main/settings_main.js » ('j') | chrome/browser/resources/settings/settings_main/settings_main.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html dir="$i18n{textdirection}" lang="$i18n{language}">	2 <html dir="$i18n{textdirection}" lang="$i18n{language}">

3 <head>	3 <head>

4 <meta charset="utf-8">	4 <meta charset="utf-8">

5 <title>$i18n{settings}</title>	5 <title>$i18n{settings}</title>

6 <link rel="import" href="chrome://resources/html/polymer.html">	6 <link rel="import" href="chrome://resources/html/polymer.html">

7 <link rel="import" href="/i18n_setup.html">	7 <link rel="import" href="/i18n_setup.html">

8 <link rel="import" href="/direction_delegate.html">	8 <link rel="import" href="/direction_delegate.html">

9 <link rel="import" href="/settings_ui/settings_ui.html">	9 <link rel="import" href="/settings_ui/settings_ui.html">

10 <link rel="import" href="/prefs/prefs.html">	10 <link rel="import" href="/prefs/prefs.html">

11 <link rel="import" href="/route.html">	11 <link rel="import" href="/route.html">

12 <link rel="import" href="/settings_vars_css.html">	12 <link rel="import" href="/settings_vars_css.html">

13 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">	13 <link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">

	14 <link rel="import" href="chrome://resources/html/i18n_template.html">

	15 <!-- Do not add any <link rel="..."> elements below here. Imports outside of

	16 <head> are disallowed by the spec and cause undefined behavior that

	17 confuses Polymer's lifecycle methods: crbug.com/638074. -->

14 </head>	18 </head>

15 <body>	19 <body>

16	20

17 <dom-module id="cr-settings">	21 <dom-module id="cr-settings">

18 <template>	22 <template>

19 <style>	23 <style>

20 :host {	24 :host {

21 color: var(--paper-grey-800);	25 color: var(--paper-grey-800);

22 }	26 }

23 </style>	27 </style>

24 <settings-prefs id="prefs" prefs="{{prefs_}}"></settings-prefs>	28 <settings-prefs id="prefs" prefs="{{prefs_}}"></settings-prefs>

25 <settings-ui id="ui" prefs="{{prefs_}}"></settings-ui>	29 <settings-ui id="ui" prefs="{{prefs_}}"></settings-ui>

26 </template>	30 </template>

27 <script src="/settings.js"></script>	31 <script src="/settings.js"></script>

28 </dom-module>	32 </dom-module>

29	33

30 <cr-settings></cr-settings>	34 <cr-settings></cr-settings>

31 <link rel="import" href="chrome://resources/html/i18n_template.html">

32 </body>	35 </body>

33 </html>	36 </html>

OLD	NEW