Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2259133002: Detect CRC32 instructions on ARMv8. (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Detect CRC32 instructions on ARMv8. I have successfully detected CRC32 instruction support on my Nexus 5x. Use of these instructions to follow... I am not yet sure which compilers if any will give me instrinsics or let me write them in asm. defined(__ARM_FEATURE_CRC32) should cover users like Android Framework who build with the best settings possible. cpu-features.h covers use cases like Clank and our bots. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2259133002 Committed: https://skia.googlesource.com/skia/+/f1b6030b44a4a9523183c3809a165b6b5353fff5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/core/SkCpu.h View 2 chunks +5 lines, -0 lines 0 comments Download
M src/core/SkCpu.cpp View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
mtklein_C
4 years, 4 months ago (2016-08-18 22:30:11 UTC) #9
msarett
lgtm
4 years, 4 months ago (2016-08-18 22:33:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259133002/1
4 years, 4 months ago (2016-08-18 22:34:38 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 22:59:12 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f1b6030b44a4a9523183c3809a165b6b5353fff5

Powered by Google App Engine
This is Rietveld 408576698