Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2259093003: Move native "enable-webapk" check to ChromeWebApkHost. (Closed)

Created:
4 years, 4 months ago by Xi Han
Modified:
4 years, 4 months ago
Reviewers:
Yaron
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move native "enable-webapk" check to ChromeWebApkHost. BUG=609258 Committed: https://crrev.com/563f35371daee357307c48347636df77d91dfbaf Cr-Commit-Position: refs/heads/master@{#413224}

Patch Set 1 #

Patch Set 2 : Nits. #

Patch Set 3 : Fix compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/ChromeWebApkHost.java View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/android/webapk/chrome_webapk_host.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/android/webapk/chrome_webapk_host.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Xi Han
Hi Yaron, could you please take a look? Thanks!
4 years, 4 months ago (2016-08-19 17:28:12 UTC) #3
Yaron
lgtm
4 years, 4 months ago (2016-08-19 17:54:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2259093003/60001
4 years, 4 months ago (2016-08-19 18:59:33 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 4 months ago (2016-08-19 20:09:26 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 20:12:49 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/563f35371daee357307c48347636df77d91dfbaf
Cr-Commit-Position: refs/heads/master@{#413224}

Powered by Google App Engine
This is Rietveld 408576698