New accessibility virtual keyboard behavior in non-sticky mode.

ui/base/ime/input_method_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/ime/input_method_base.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 41 matching lines @@
 void InputMethodBase::DetachTextInputClient(TextInputClient* client) {
   if (text_input_client_ != client)
     return;
   SetFocusedTextInputClientInternal(nullptr);
 }
 
 TextInputClient* InputMethodBase::GetTextInputClient() const {
   return text_input_client_;
 }
 
+void InputMethodBase::set_available_bounds(gfx::Rect new_bounds) {
+  available_bounds_ = new_bounds;
+  if (text_input_client_)
+    text_input_client_->EnsureCaretInRect(available_bounds_);
+}
+
 void InputMethodBase::OnTextInputTypeChanged(const TextInputClient* client) {
   if (!IsTextInputClientFocused(client))
     return;
   NotifyTextInputStateChanged(client);
 }
 
 TextInputType InputMethodBase::GetTextInputType() const {
   TextInputClient* client = GetTextInputClient();
   return client ? client->GetTextInputType() : TEXT_INPUT_TYPE_NONE;
 }
@@ skipping 62 matching lines @@
 
 void InputMethodBase::SetFocusedTextInputClientInternal(
     TextInputClient* client) {
   TextInputClient* old = text_input_client_;
   if (old == client)
     return;
   OnWillChangeFocusedClient(old, client);
   text_input_client_ = client;  // nullptr allowed.
   OnDidChangeFocusedClient(old, client);
   NotifyTextInputStateChanged(text_input_client_);
+
+  if (available_bounds_.IsEmpty())
+    return;
+
+  // Restore old focused window if moved.
+  if (old) {

[sky, 2016/08/19 00:16:40]

In general chrome style is no {} around single line ifs. For example, see line
144/145 above.

[hariank, 2016/08/19 00:45:38]

Done.

+    old->EnsureCaretInRect(available_bounds_);

[sky, 2016/08/19 00:16:40]

Why do you need to notify the previous TextInputClient here?

[hariank, 2016/08/19 00:45:38]

The previous TextInputClient's window should be restored if it was moved. When
the keyboard is closed, the active (most recently moved) window is restored, but
not all the previously moved windows. So, whenever focus is changed the previous
window is restored.

[sky, 2016/08/19 03:47:24]

That makes sense. I would never expect a function named EnsureCaretInRect to
handle restore. You should add an explicit function for this to TextInputClient.
Maybe something like OnNoLongerActiveTextInputClient. That names is wordy, but
you get the idea.

[hariank, 2016/08/19 17:54:39]

Ok, added an OnClientFocusLost function.

+  }
+  // Move new focused window if necessary.
+  if (text_input_client_) {
+    text_input_client_->EnsureCaretInRect(available_bounds_);
+  }
 }
 
 std::vector<gfx::Rect> InputMethodBase::GetCompositionBounds(
     const TextInputClient* client) {
   std::vector<gfx::Rect> bounds;
   if (client->HasCompositionText()) {
     uint32_t i = 0;
     gfx::Rect rect;
     while (client->GetCompositionCharacterBounds(i++, &rect))
       bounds.push_back(rect);
@@ skipping 56 matching lines @@
 InputMethod* InputMethodBase::GetInputMethod() {
   return this;
 }
 
 const std::vector<std::unique_ptr<ui::KeyEvent>>&
 InputMethodBase::GetKeyEventsForTesting() {
   return key_events_for_testing_;
 }
 
 }  // namespace ui