Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: Source/core/frame/LocalDOMWindow.cpp

Issue 225903009: Migrate touch events to EventHandlerRegistry (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed HTMLInputElement adding handler at document destruction and removed dead oilpan code. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/LocalDOMWindow.cpp
diff --git a/Source/core/frame/LocalDOMWindow.cpp b/Source/core/frame/LocalDOMWindow.cpp
index d79c1e87bbf42493003ab21c7e08523183198156..8109a3343a991d88082585244f6b7da55f61f867 100644
--- a/Source/core/frame/LocalDOMWindow.cpp
+++ b/Source/core/frame/LocalDOMWindow.cpp
@@ -412,11 +412,6 @@ PassRefPtrWillBeRawPtr<Document> LocalDOMWindow::installNewDocument(const String
}
m_frame->selection().updateSecureKeyboardEntryIfActive();
-
- if (m_frame->isMainFrame()) {
- if (m_document->hasTouchEventHandlers())
- m_frame->host()->chrome().client().needTouchEvents(true);
- }
return m_document;
}
@@ -1539,9 +1534,7 @@ bool LocalDOMWindow::addEventListener(const AtomicString& eventType, PassRefPtr<
if (Document* document = this->document()) {
document->addListenerTypeIfNeeded(eventType);
- if (isTouchEventType(eventType))
- document->didAddTouchEventHandler(document);
- else if (eventType == EventTypeNames::storage)
+ if (eventType == EventTypeNames::storage)
didAddStorageEventListener(this);
}
@@ -1574,11 +1567,6 @@ bool LocalDOMWindow::removeEventListener(const AtomicString& eventType, EventLis
if (m_frame && m_frame->host())
m_frame->host()->eventHandlerRegistry().didRemoveEventHandler(*this, eventType);
- if (Document* document = this->document()) {
- if (isTouchEventType(eventType))
- document->didRemoveTouchEventHandler(document);
- }
-
lifecycleNotifier().notifyRemoveEventListener(this, eventType);
if (eventType == EventTypeNames::unload) {
@@ -1647,9 +1635,6 @@ void LocalDOMWindow::removeAllEventListenersInternal(BroadcastListenerRemoval mo
if (mode == DoBroadcastListenerRemoval) {
if (m_frame && m_frame->host())
m_frame->host()->eventHandlerRegistry().didRemoveAllEventHandlers(*this);
-
- if (Document* document = this->document())
- document->didClearTouchEventHandlers(document);
}
removeAllUnloadEventListeners(this);

Powered by Google App Engine
This is Rietveld 408576698