Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(793)

Unified Diff: Source/core/dom/Document.cpp

Issue 225903009: Migrate touch events to EventHandlerRegistry (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index d369a5ec7df561bb902763ea6f8a21b031f2bdde..ec8f91bfb6991134bf1292066036362b3c11138d 100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -2236,9 +2236,6 @@ void Document::detach(const AttachContext& context)
m_styleEngine->didDetach();
- if (Document* parentDoc = parentDocument())
- parentDoc->didClearTouchEventHandlers(this);
-
// This is required, as our LocalFrame might delete itself as soon as it detaches
// us. However, this violates Node::detach() semantics, as it's never
// possible to re-attach. Eventually Document::detach() should be renamed,
@@ -5276,80 +5273,6 @@ PassRefPtrWillBeRawPtr<TouchList> Document::createTouchList(WillBeHeapVector<Ref
return TouchList::create(touches);
}
-void Document::didAddTouchEventHandler(Node* handler)
-{
- // The node should either be in this document, or be the Document node of a child
- // of this document.
- ASSERT(&handler->document() == this
- || (handler->isDocumentNode() && toDocument(handler)->parentDocument() == this));
- if (!m_touchEventTargets.get())
- m_touchEventTargets = adoptPtr(new TouchEventTargetSet);
- bool isFirstHandler = m_touchEventTargets->isEmpty();
-
- if (!m_touchEventTargets->add(handler).isNewEntry) {
- // Just incremented refcount, no real change.
- // If this is a child document node, then the count should never go above 1.
- ASSERT(!handler->isDocumentNode() || &handler->document() == this);
- return;
- }
-
- if (isFirstHandler) {
- if (Document* parent = parentDocument()) {
- parent->didAddTouchEventHandler(this);
- } else {
- // This is the first touch handler on the whole page.
- if (FrameHost* frameHost = this->frameHost())
- frameHost->chrome().client().needTouchEvents(true);
- }
- }
-
- // When we're all done with all frames, ensure touch hit rects are marked as dirty.
- if (!handler->isDocumentNode() || handler == this) {
- if (Page* page = this->page()) {
- if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
- scrollingCoordinator->touchEventTargetRectsDidChange();
- }
- }
-}
-
-void Document::didRemoveTouchEventHandler(Node* handler, bool clearAll)
-{
- // Note that we can't assert that |handler| is in this document because it might be in
- // the process of moving out of it.
- ASSERT(clearAll || m_touchEventTargets->contains(handler));
- if (!m_touchEventTargets.get())
- return;
-
- if (clearAll) {
- if (!m_touchEventTargets->contains(handler))
- return;
- m_touchEventTargets->removeAll(handler);
- } else {
- if (!m_touchEventTargets->remove(handler))
- // Just decremented refcount, no real update.
- return;
- }
-
- if (m_touchEventTargets->isEmpty()) {
- if (Document* parent = parentDocument()) {
- // This was the last handler in this document, update the parent document too.
- parent->didRemoveTouchEventHandler(this, clearAll);
- } else {
- // We just removed the last touch handler on the whole page.
- if (FrameHost* frameHost = this->frameHost())
- frameHost->chrome().client().needTouchEvents(false);
- }
- }
-
- // When we're all done with all frames, ensure touch hit rects are marked as dirty.
- if (!handler->isDocumentNode() || handler == this) {
- if (Page* page = this->page()) {
- if (ScrollingCoordinator* scrollingCoordinator = page->scrollingCoordinator())
- scrollingCoordinator->touchEventTargetRectsDidChange();
- }
- }
-}
-
DocumentLoader* Document::loader() const
{
if (!m_frame)
@@ -5794,17 +5717,6 @@ void Document::clearWeakMembers(Visitor* visitor)
{
if (m_axObjectCache)
m_axObjectCache->clearWeakMembers(visitor);
-
- // FIXME: Oilpan: Use a weak counted set instead.
- if (m_touchEventTargets) {
- Vector<Node*> deadNodes;
- for (TouchEventTargetSet::iterator it = m_touchEventTargets->begin(); it != m_touchEventTargets->end(); ++it) {
- if (!visitor->isAlive(it->key))
- deadNodes.append(it->key);
- }
- for (unsigned i = 0; i < deadNodes.size(); ++i)
- didClearTouchEventHandlers(deadNodes[i]);
- }
}
void Document::trace(Visitor* visitor)

Powered by Google App Engine
This is Rietveld 408576698