Migrate touch events to EventHandlerRegistry

Source/core/frame/EventHandlerRegistry.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/frame/EventHandlerRegistry.h"
 
 #include "core/events/ThreadLocalEventNames.h"
 #include "core/frame/DOMWindow.h"
 #include "core/frame/LocalFrame.h"
 #include "core/html/HTMLFrameOwnerElement.h"
+#include "core/page/Chrome.h"
+#include "core/page/ChromeClient.h"
 #include "core/page/Page.h"
 #include "core/page/scrolling/ScrollingCoordinator.h"
 
 namespace WebCore {
 
 EventHandlerRegistry::EventHandlerRegistry(FrameHost& frameHost)
     : m_frameHost(frameHost)
 {
 }
 
 EventHandlerRegistry::~EventHandlerRegistry()
 {
     checkConsistency();
 }
 
 bool EventHandlerRegistry::eventTypeToClass(const AtomicString& eventType, EventHandlerClass* result)
 {
     if (eventType == EventTypeNames::scroll) {
         *result = ScrollEvent;
     } else if (eventType == EventTypeNames::wheel || eventType == EventTypeNames::mousewheel) {
         *result = WheelEvent;
+    } else if (isTouchEventType(eventType)) {
+        *result = TouchEvent;
 #if ASSERT_ENABLED
     } else if (eventType == EventTypeNames::load || eventType == EventTypeNames::mousemove || eventType == EventTypeNames::touchstart) {
         *result = EventsForTesting;
 #endif
     } else {
         return false;
     }
     return true;
 }
 
 const EventTargetSet* EventHandlerRegistry::eventHandlerTargets(EventHandlerClass handlerClass) const
 {
     checkConsistency();
     return &m_targets[handlerClass];
 }
 
 bool EventHandlerRegistry::hasEventHandlers(EventHandlerClass handlerClass) const
 {
+    checkConsistency();
     return m_targets[handlerClass].size();
 }
 
 bool EventHandlerRegistry::updateEventHandlerTargets(ChangeOperation op, EventHandlerClass handlerClass, EventTarget* target)
 {
     EventTargetSet* targets = &m_targets[handlerClass];
     if (op == Add) {
         if (!targets->add(target).isNewEntry) {
             // Just incremented refcount, no real change.
             return false;
@@ skipping 11 matching lines @@
                 // Just decremented refcount, no real update.
                 return false;
             }
         }
     }
     return true;
 }
 
 void EventHandlerRegistry::updateEventHandlerInternal(ChangeOperation op, EventHandlerClass handlerClass, EventTarget* target)
 {
-    bool hadHandlers = hasEventHandlers(handlerClass);
-    updateEventHandlerTargets(op, handlerClass, target);
-    bool hasHandlers = hasEventHandlers(handlerClass);
+    bool hadHandlers = m_targets[handlerClass].size();
+    bool targetSetChanged = updateEventHandlerTargets(op, handlerClass, target);
+    bool hasHandlers = m_targets[handlerClass].size();
 
-    if (hadHandlers != hasHandlers) {
+    if (hadHandlers != hasHandlers)
         notifyHasHandlersChanged(handlerClass, hasHandlers);
-    }
-    checkConsistency();
+
+    if (targetSetChanged)
+        notifyDidAddOrRemoveEventHandlerTarget(handlerClass);
 }
 
 void EventHandlerRegistry::updateEventHandlerOfType(ChangeOperation op, const AtomicString& eventType, EventTarget* target)
 {
     EventHandlerClass handlerClass;
     if (!eventTypeToClass(eventType, &handlerClass))
         return;
     updateEventHandlerInternal(op, handlerClass, target);
 }
 
@@ skipping 10 matching lines @@
 void EventHandlerRegistry::didAddEventHandler(EventTarget& target, EventHandlerClass handlerClass)
 {
     updateEventHandlerInternal(Add, handlerClass, &target);
 }
 
 void EventHandlerRegistry::didRemoveEventHandler(EventTarget& target, EventHandlerClass handlerClass)
 {
     updateEventHandlerInternal(Remove, handlerClass, &target);
 }
 
-void EventHandlerRegistry::didMoveIntoFrameHost(EventTarget& target)
+void EventHandlerRegistry::didMoveBetweenFrameHosts(EventTarget& target, FrameHost* oldFrameHost, FrameHost* newFrameHost)
 {
-    updateAllEventHandlers(Add, target);
-}
+    ASSERT(newFrameHost || oldFrameHost);
+    ASSERT(newFrameHost != oldFrameHost);
+    if (newFrameHost && !oldFrameHost) {

[Rick Byers, 2014/06/19 17:10:36]

this code reads like it should really be 3 functions (none of which permit null
arguments), not one function with 3 overloaded scenarios. 

[Sami, 2014/06/27 17:58:51]

Agreed, let me clean this up.

[Rick Byers, 2014/06/27 21:36:51]

Looks better, thanks.

+        if (!target.hasEventListeners())
+            return;
 
-void EventHandlerRegistry::didMoveOutOfFrameHost(EventTarget& target)
-{
-    updateAllEventHandlers(RemoveAll, target);
+        Vector<AtomicString> eventTypes = target.eventTypes();
+        for (size_t i = 0; i < eventTypes.size(); ++i) {
+            EventHandlerClass handlerClass;
+            if (!eventTypeToClass(eventTypes[i], &handlerClass))
+                continue;
+            for (unsigned count = target.getEventListeners(eventTypes[i]).size(); count > 0; --count)
+                newFrameHost->eventHandlerRegistry().didAddEventHandler(target, handlerClass);
+        }
+    } else if (!newFrameHost && oldFrameHost) {
+        oldFrameHost->eventHandlerRegistry().didRemoveAllEventHandlers(target);
+    } else if (newFrameHost && oldFrameHost) {
+        for (size_t i = 0; i < EventHandlerClassCount; ++i) {
+            EventHandlerClass handlerClass = static_cast<EventHandlerClass>(i);
+            const EventTargetSet* targets = &oldFrameHost->eventHandlerRegistry().m_targets[handlerClass];
+            for (unsigned count = targets->count(&target); count > 0; --count)
+                newFrameHost->eventHandlerRegistry().didAddEventHandler(target, handlerClass);
+            oldFrameHost->eventHandlerRegistry().didRemoveAllEventHandlers(target);
+        }
+    }
 }
 
 void EventHandlerRegistry::didRemoveAllEventHandlers(EventTarget& target)
 {
     for (size_t i = 0; i < EventHandlerClassCount; ++i) {
         EventHandlerClass handlerClass = static_cast<EventHandlerClass>(i);
         updateEventHandlerInternal(RemoveAll, handlerClass, &target);
     }
 }
 
-void EventHandlerRegistry::updateAllEventHandlers(ChangeOperation op, EventTarget& target)
-{
-    if (!target.hasEventListeners())
-        return;
-
-    Vector<AtomicString> eventTypes = target.eventTypes();
-    for (size_t i = 0; i < eventTypes.size(); ++i) {
-        EventHandlerClass handlerClass;
-        if (!eventTypeToClass(eventTypes[i], &handlerClass))
-            continue;
-        if (op == RemoveAll) {
-            updateEventHandlerInternal(op, handlerClass, &target);
-            continue;
-        }
-        for (unsigned count = target.getEventListeners(eventTypes[i]).size(); count > 0; --count)
-            updateEventHandlerInternal(op, handlerClass, &target);
-    }
-}
-
 void EventHandlerRegistry::notifyHasHandlersChanged(EventHandlerClass handlerClass, bool hasActiveHandlers)
 {
     ScrollingCoordinator* scrollingCoordinator = m_frameHost.page().scrollingCoordinator();
 
     switch (handlerClass) {
     case ScrollEvent:
         if (scrollingCoordinator)
             scrollingCoordinator->updateHaveScrollEventHandlers();
         break;
     case WheelEvent:
         if (scrollingCoordinator)
             scrollingCoordinator->updateHaveWheelEventHandlers();
         break;
+    case TouchEvent:
+        m_frameHost.chrome().client().needTouchEvents(hasActiveHandlers);
+        break;
 #if ASSERT_ENABLED
     case EventsForTesting:
         break;
 #endif
     default:
         ASSERT_NOT_REACHED();
         break;
     }
 }
 
+void EventHandlerRegistry::notifyDidAddOrRemoveEventHandlerTarget(EventHandlerClass handlerClass)
+{
+    ScrollingCoordinator* scrollingCoordinator = m_frameHost.page().scrollingCoordinator();
+    if (scrollingCoordinator && handlerClass == TouchEvent)
+        scrollingCoordinator->touchEventTargetRectsDidChange();
+}
+
 void EventHandlerRegistry::trace(Visitor* visitor)
 {
     visitor->registerWeakMembers<EventHandlerRegistry, &EventHandlerRegistry::clearWeakMembers>(this);
 }
 
 void EventHandlerRegistry::clearWeakMembers(Visitor* visitor)
 {
     Vector<EventTarget*> deadTargets;
     for (size_t i = 0; i < EventHandlerClassCount; ++i) {
         EventHandlerClass handlerClass = static_cast<EventHandlerClass>(i);
@@ skipping 56 matching lines @@
                 ASSERT(window->frame());
                 ASSERT(window->frame()->host());
                 ASSERT(window->frame()->host() == &m_frameHost);
             }
         }
     }
 #endif // ASSERT_ENABLED
 }
 
 } // namespace WebCore