LayoutTests/fast/events/touch/touch-action-touch-handlers.html - Issue 225903009: Migrate touch events to EventHandlerRegistry

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/events/touch/touch-action-touch-handlers.html

Issue 225903009: Migrate touch events to EventHandlerRegistry (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebased. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script src="../../../resources/js-test.js"></script>	4 <script src="../../../resources/js-test.js"></script>

5 <style>	5 <style>

6 #touchActionDiv {	6 #touchActionDiv {

7 height: 50px;	7 height: 50px;

8 width: 200px;	8 width: 200px;

9 border: 1px solid blue;	9 border: 1px solid blue;

10 }	10 }

(...skipping 80 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91 div.style.touchAction = "auto";	91 div.style.touchAction = "auto";

92 shouldBe("getTouchHandlerCount(document)", "1");	92 shouldBe("getTouchHandlerCount(document)", "1");

93	93

94 debug("touch-action on div inside frame should add a handler");	94 debug("touch-action on div inside frame should add a handler");

95 var iframe = document.createElement("iframe");	95 var iframe = document.createElement("iframe");

96 document.body.appendChild(iframe);	96 document.body.appendChild(iframe);

97 nestedDocument = iframe.contentWindow.document;	97 nestedDocument = iframe.contentWindow.document;

98 nestedDocument.open('text/html', 'replace');	98 nestedDocument.open('text/html', 'replace');

99 nestedDocument.write("<!DOCTYPE html>\n<div style='touch-action: none'></div >");	99 nestedDocument.write("<!DOCTYPE html>\n<div style='touch-action: none'></div >");

100 window.internals.forceCompositingUpdate(document);	100 window.internals.forceCompositingUpdate(document);

101 shouldBe("getTouchHandlerCount(nestedDocument)", "1");	101 shouldBe("getTouchHandlerCount(nestedDocument)", "2");
	Rick Byers 2014/06/19 17:10:36 why this change? I'd expect 1. why this change? I'd expect 1. Sami 2014/06/27 17:58:51 Both documents now point to the same (global) regi Show quoted text On 2014/06/19 17:10:36, Rick Byers wrote: > why this change? I'd expect 1. Both documents now point to the same (global) registry, so the counts are equal. The first handler is the div.style.touchAction on the main document and the second one is a similar one in the child document. Rick Byers 2014/06/27 21:36:51 Ah, of course - thanks. Show quoted text On 2014/06/27 17:58:51, Sami wrote: > On 2014/06/19 17:10:36, Rick Byers wrote: > > why this change? I'd expect 1. > > Both documents now point to the same (global) registry, so the counts are equal. > The first handler is the div.style.touchAction on the main document and the > second one is a similar one in the child document. Ah, of course - thanks.
102 shouldBe("getTouchHandlerCount(document)", "2");	102 shouldBe("getTouchHandlerCount(document)", "2");

103 }	103 }

104 </script>	104 </script>

105 </body>	105 </body>

106 </html>	106 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/events/touch/touch-action-touch-handlers-expected.txt » ('j') | Source/core/dom/Node.cpp » ('J')