Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h

Issue 2259013003: Move and rename TaskTimeTracker to public interface exposed to WebThread, use in WebPerf Agent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch TaskTimeTracker over to WebThread::TaskTimeObserver Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
index 77705b4627e7dc60e28fb7bebe752781e99bd79e..f71e856d08257e9f83a7d90fd4526b95bcc4e34b 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
@@ -8,7 +8,6 @@
#include "base/atomicops.h"
#include "base/macros.h"
#include "base/synchronization/lock.h"
-#include "platform/scheduler/base/long_task_tracker.h"
#include "platform/scheduler/base/pollable_thread_safe_flag.h"
#include "platform/scheduler/base/queueing_time_estimator.h"
#include "platform/scheduler/base/task_time_tracker.h"
@@ -41,7 +40,7 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
public IdleHelper::Delegate,
public SchedulerHelper::Observer,
public RenderWidgetSignals::Observer,
- public TaskTimeTracker,
+ public WebThread::TaskTimeObserver,
public QueueingTimeEstimator::Client {
public:
// Keep RendererScheduler::UseCaseToString in sync with this enum.
@@ -130,9 +129,10 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
void OnTriedToExecuteBlockedTask(const TaskQueue& queue,
const base::PendingTask& task) override;
- // TaskTimeTracker implementation:
- void ReportTaskTime(base::TimeTicks start_time,
- base::TimeTicks end_time) override;
+ // WebThread::TaskTimeObserver implementation.
+ void willProcessTask() override { }
+ void didProcessTask() override { }
+ void reportTaskTime(double start_time, double end_time) override;
// QueueingTimeEstimator::Client implementation:
void OnQueueingTimeForWindowEstimated(base::TimeDelta queueing_time) override;
@@ -149,7 +149,8 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
void AddWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler);
void RemoveWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler);
- LongTaskTracker::LongTaskTiming GetLongTaskTiming();
+ void AddTaskTimeObserver(WebThread::TaskTimeObserver* task_time_observer);
+ void RemoveTaskTimeObserver(WebThread::TaskTimeObserver* task_time_observer);
// Test helpers.
SchedulerHelper* GetSchedulerHelperForTesting();
@@ -380,7 +381,6 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
TaskCostEstimator loading_task_cost_estimator;
TaskCostEstimator timer_task_cost_estimator;
QueueingTimeEstimator queueing_time_estimator;
- LongTaskTracker long_task_tracker;
IdleTimeEstimator idle_time_estimator;
UseCase current_use_case;
Policy current_policy;

Powered by Google App Engine
This is Rietveld 408576698