Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h

Issue 2259013003: Move and rename TaskTimeTracker to public interface exposed to WebThread, use in WebPerf Agent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address nit: task_start_time initialization Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
diff --git a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
index 09a7094e7b0163b262447cf08f6738939ad7d598..c74a413b94cd73b173ed4e2197e6f1f713e1120e 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
+++ b/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
@@ -7,6 +7,8 @@
#include "core/CoreExport.h"
#include "platform/heap/Handle.h"
+#include "public/platform/WebThread.h"
+#include "public/platform/scheduler/base/task_time_observer.h"
namespace blink {
@@ -15,16 +17,26 @@ class LocalFrame;
class InspectedFrames;
// Inspector Agent for Web Performance APIs
-class CORE_EXPORT InspectorWebPerfAgent final : public GarbageCollectedFinalized<InspectorWebPerfAgent> {
+class CORE_EXPORT InspectorWebPerfAgent final
+ : public GarbageCollectedFinalized<InspectorWebPerfAgent>
+ , public WebThread::TaskObserver
caseq 2016/08/26 22:42:25 style: nuke extra space before public
panicker 2016/08/26 23:57:39 Done.
+ , public scheduler::TaskTimeObserver {
caseq 2016/08/26 22:42:25 ditto
panicker 2016/08/26 23:57:39 Done.
WTF_MAKE_NONCOPYABLE(InspectorWebPerfAgent);
public:
- InspectorWebPerfAgent(InspectedFrames*);
+ explicit InspectorWebPerfAgent(InspectedFrames*);
~InspectorWebPerfAgent();
DECLARE_VIRTUAL_TRACE();
void willExecuteScript(ExecutionContext*);
void didExecuteScript();
+ // WebThread::TaskObserver implementation.
+ void willProcessTask() override;
+ void didProcessTask() override;
+
+ // scheduler::TaskTimeObserver implementation
+ void ReportTaskTime(double startTime, double endTime) override;
+
private:
Member<InspectedFrames> m_inspectedFrames;
};

Powered by Google App Engine
This is Rietveld 408576698