Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h

Issue 2259013003: Move and rename TaskTimeTracker to public interface exposed to WebThread, use in WebPerf Agent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Move TaskTimeTracker to public interface, expose to WebThread. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
index 0e6a3d500605d05b30529d680fe9a5620252f060..366a3b12b06f8b2c025c86eeca4108a2255bd91a 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
@@ -8,20 +8,19 @@
#include "base/atomicops.h"
#include "base/macros.h"
#include "base/synchronization/lock.h"
-#include "platform/scheduler/base/long_task_tracker.h"
#include "platform/scheduler/base/pollable_thread_safe_flag.h"
#include "platform/scheduler/base/queueing_time_estimator.h"
-#include "platform/scheduler/base/task_time_tracker.h"
#include "platform/scheduler/child/idle_helper.h"
#include "platform/scheduler/child/scheduler_helper.h"
#include "platform/scheduler/renderer/deadline_task_runner.h"
#include "platform/scheduler/renderer/idle_time_estimator.h"
#include "platform/scheduler/renderer/render_widget_signals.h"
-#include "public/platform/scheduler/renderer/renderer_scheduler.h"
#include "platform/scheduler/renderer/task_cost_estimator.h"
#include "platform/scheduler/renderer/throttling_helper.h"
#include "platform/scheduler/renderer/user_model.h"
#include "platform/scheduler/renderer/web_view_scheduler_impl.h"
+#include "public/platform/scheduler/renderer/renderer_scheduler.h"
+#include "public/platform/scheduler/base/task_time_tracker.h"
namespace base {
namespace trace_event {
@@ -131,8 +130,7 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
const base::PendingTask& task) override;
// TaskTimeTracker implementation:
- void ReportTaskTime(base::TimeTicks start_time,
- base::TimeTicks end_time) override;
+ void ReportTaskTime(double start_time, double end_time) override;
// QueueingTimeEstimator::Client implementation:
void OnQueueingTimeForWindowEstimated(base::TimeDelta queueing_time) override;
@@ -149,7 +147,8 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
void AddWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler);
void RemoveWebViewScheduler(WebViewSchedulerImpl* web_view_scheduler);
- LongTaskTracker::LongTaskTiming GetLongTaskTiming();
+ void AddTaskTimeTracker(TaskTimeTracker* task_time_tracker);
+ void RemoveTaskTimeTracker(TaskTimeTracker* task_time_tracker);
// Test helpers.
SchedulerHelper* GetSchedulerHelperForTesting();
@@ -369,7 +368,6 @@ class BLINK_PLATFORM_EXPORT RendererSchedulerImpl
TaskCostEstimator loading_task_cost_estimator;
TaskCostEstimator timer_task_cost_estimator;
QueueingTimeEstimator queueing_time_estimator;
- LongTaskTracker long_task_tracker;
IdleTimeEstimator idle_time_estimator;
UseCase current_use_case;
Policy current_policy;

Powered by Google App Engine
This is Rietveld 408576698