Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: third_party/WebKit/Source/platform/scheduler/child/webthread_base.cc

Issue 2259013003: Move and rename TaskTimeTracker to public interface exposed to WebThread, use in WebPerf Agent. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switch TaskTimeTracker over to WebThread::TaskTimeObserver Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // An implementation of WebThread in terms of base::MessageLoop and 5 // An implementation of WebThread in terms of base::MessageLoop and
6 // base::Thread 6 // base::Thread
7 7
8 #include "public/platform/scheduler/child/webthread_base.h" 8 #include "public/platform/scheduler/child/webthread_base.h"
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 void WebThreadBase::removeTaskObserver(TaskObserver* observer) { 56 void WebThreadBase::removeTaskObserver(TaskObserver* observer) {
57 CHECK(isCurrentThread()); 57 CHECK(isCurrentThread());
58 TaskObserverMap::iterator iter = task_observer_map_.find(observer); 58 TaskObserverMap::iterator iter = task_observer_map_.find(observer);
59 if (iter == task_observer_map_.end()) 59 if (iter == task_observer_map_.end())
60 return; 60 return;
61 RemoveTaskObserverInternal(iter->second); 61 RemoveTaskObserverInternal(iter->second);
62 delete iter->second; 62 delete iter->second;
63 task_observer_map_.erase(iter); 63 task_observer_map_.erase(iter);
64 } 64 }
65 65
66 void WebThreadBase::addTaskTimeObserver(TaskTimeObserver* task_time_observer) {
67 AddTaskTimeObserverInternal(task_time_observer);
alph 2016/08/22 22:21:27 nit: something wrong with indentation here.
panicker 2016/08/22 23:14:15 Acknowledged.
68 }
69
70 void WebThreadBase::removeTaskTimeObserver(TaskTimeObserver* task_time_observer) {
71 RemoveTaskTimeObserverInternal(task_time_observer);
72 }
73
66 void WebThreadBase::AddTaskObserverInternal( 74 void WebThreadBase::AddTaskObserverInternal(
67 base::MessageLoop::TaskObserver* observer) { 75 base::MessageLoop::TaskObserver* observer) {
68 base::MessageLoop::current()->AddTaskObserver(observer); 76 base::MessageLoop::current()->AddTaskObserver(observer);
69 } 77 }
70 78
71 void WebThreadBase::RemoveTaskObserverInternal( 79 void WebThreadBase::RemoveTaskObserverInternal(
72 base::MessageLoop::TaskObserver* observer) { 80 base::MessageLoop::TaskObserver* observer) {
73 base::MessageLoop::current()->RemoveTaskObserver(observer); 81 base::MessageLoop::current()->RemoveTaskObserver(observer);
74 } 82 }
75 83
(...skipping 18 matching lines...) Expand all
94 location, base::Bind(&WebThreadBase::RunWebThreadIdleTask, 102 location, base::Bind(&WebThreadBase::RunWebThreadIdleTask,
95 base::Passed(base::WrapUnique(idle_task)))); 103 base::Passed(base::WrapUnique(idle_task))));
96 } 104 }
97 105
98 bool WebThreadBase::isCurrentThread() const { 106 bool WebThreadBase::isCurrentThread() const {
99 return GetTaskRunner()->BelongsToCurrentThread(); 107 return GetTaskRunner()->BelongsToCurrentThread();
100 } 108 }
101 109
102 } // namespace scheduler 110 } // namespace scheduler
103 } // namespace blink 111 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698